Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2536803002: Remove ThreadRestrictions::ScopedAllowSingleton. (Closed)

Created:
4 years ago by fdoray
Modified:
4 years ago
Reviewers:
brettw
CC:
chromium-reviews, cbentzel+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ThreadRestrictions::ScopedAllowSingleton. It's used in two files that don't really need it. BUG= Committed: https://crrev.com/b144619bf8646474ce7f4595c809b7587a9de51c Cr-Commit-Position: refs/heads/master@{#436410}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -28 lines) Patch
M base/threading/thread_restrictions.h View 1 chunk +0 lines, -14 lines 0 comments Download
M ios/web/web_thread_impl.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M net/base/keygen_handler_unittest.cc View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
fdoray
PTAL
4 years ago (2016-11-29 16:01:46 UTC) #7
brettw
lgtm
4 years ago (2016-12-05 18:28:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536803002/1
4 years ago (2016-12-05 18:29:26 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-05 21:25:26 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-05 21:29:53 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b144619bf8646474ce7f4595c809b7587a9de51c
Cr-Commit-Position: refs/heads/master@{#436410}

Powered by Google App Engine
This is Rietveld 408576698