Removed android scrolling fake mouse moves and device_supports_mouse

third_party/WebKit/Source/web/DevToolsEmulator.cpp

Index: third_party/WebKit/Source/web/DevToolsEmulator.cpp
diff --git a/third_party/WebKit/Source/web/DevToolsEmulator.cpp b/third_party/WebKit/Source/web/DevToolsEmulator.cpp
index 1d33bea9aeb7eb7194c0c22a783f4460760a5865..6f5662fcf47df6f2c043d7af4aa93b6173969650 100644
--- a/third_party/WebKit/Source/web/DevToolsEmulator.cpp
+++ b/third_party/WebKit/Source/web/DevToolsEmulator.cpp
@@ -90,7 +90,6 @@ DevToolsEmulator::DevToolsEmulator(WebViewImpl* webViewImpl)
       m_touchEventEmulationEnabled(false),
       m_doubleTapToZoomEnabled(false),
       m_originalTouchEventAPIEnabled(false),
-      m_originalDeviceSupportsMouse(false),
       m_originalDeviceSupportsTouch(false),
       m_originalMaxTouchPoints(0),
       m_embedderScriptEnabled(webViewImpl->page()->settings().scriptEnabled()),
@@ -448,8 +447,6 @@ void DevToolsEmulator::setTouchEventEmulationEnabled(bool enabled) {
   if (!m_touchEventEmulationEnabled) {
     m_originalTouchEventAPIEnabled =
         RuntimeEnabledFeatures::touchEventAPIEnabled();
-    m_originalDeviceSupportsMouse =
-        m_webViewImpl->page()->settings().deviceSupportsMouse();
     m_originalDeviceSupportsTouch =
         m_webViewImpl->page()->settings().deviceSupportsTouch();
     m_originalMaxTouchPoints =
@@ -458,8 +455,6 @@ void DevToolsEmulator::setTouchEventEmulationEnabled(bool enabled) {
   RuntimeEnabledFeatures::setTouchEventAPIEnabled(
       enabled ? true : m_originalTouchEventAPIEnabled);
   if (!m_originalDeviceSupportsTouch) {
-    m_webViewImpl->page()->settings().setDeviceSupportsMouse(

[bokan, 2016/12/02 18:04:05]

We should probably clear the last known mouse location here to prevent
dispatching the fake mouse moves when emulating Android.

[amaralp, 2016/12/02 23:00:36]

 I checked locally and no fake mouse moves are dispatched during emulation even
without the clearing.

[bokan, 2016/12/07 00:09:53]

Could you find out why? As far as I can tell, if the mouse moved at all on the
page before we enter emulation then we should be dispatching these. The only
place we clear the mouse location is from MouseEventManager::clear but I don't
see how we might be calling that from here.

This is actually important since devs often use emulation to build for mobile so
its important we don't break emulation.

[amaralp, 2016/12/13 01:09:14]

I'm adding a clear just in case, but from what I can tell the fake mouse event
is created but never dispatched all the way down to javascript.

-        enabled ? false : m_originalDeviceSupportsMouse);
     m_webViewImpl->page()->settings().setDeviceSupportsTouch(
         enabled ? true : m_originalDeviceSupportsTouch);
     // Currently emulation does not provide multiple touch points.