Issue 2536683002: VM: [Kernel] Don't add implicit getters for top level fields into the library dictionary.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2536683002: VM: [Kernel] Don't add implicit getters for top level fields into the library dictionary. (Closed)

Created:
4 years ago by Vyacheslav Egorov (Google)

Modified:
4 years ago

Reviewers:
kustermann

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

VM: [Kernel] Don't add implicit getters for top level fields into the library dictionary. Tree shaker can't cope with this and produces incorrect snapshots that contains tree shaken classes. R=kustermann@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/8eceda053f49b624840f1f4098bf16458f517010

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+47 lines, -72 lines)			Patch
M	runtime/vm/kernel_reader.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	tests/co19/co19-kernel.status	View	5 chunks	+29 lines, -29 lines	0 comments	Download
M	tests/language/language_kernel.status	View	9 chunks	+18 lines, -39 lines	0 comments	Download

Total messages: 4 (1 generated)

Vyacheslav Egorov (Google)

4 years ago (2016-11-28 14:50:29 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8eceda053f49b624840f1f4098bf16458f517010 (presubmit successful).