Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: runtime/vm/kernel_reader.cc

Issue 2536683002: VM: [Kernel] Don't add implicit getters for top level fields into the library dictionary. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/co19/co19-kernel.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/kernel_reader.cc
diff --git a/runtime/vm/kernel_reader.cc b/runtime/vm/kernel_reader.cc
index 36167536e9a752c497a49bcb658732c57116fed1..e3b633f967c9ae4d55c1536616e4d82c87e77004 100644
--- a/runtime/vm/kernel_reader.cc
+++ b/runtime/vm/kernel_reader.cc
@@ -490,10 +490,6 @@ void KernelReader::GenerateFieldAccessors(const dart::Class& klass,
false, // is_native
script_class, kernel_field->position()));
klass.AddFunction(getter);
- if (klass.IsTopLevel()) {
- dart::Library& library = dart::Library::Handle(Z, klass.library());
- library.AddObject(getter, getter_name);
- }
getter.set_kernel_function(kernel_field);
getter.set_result_type(AbstractType::Handle(Z, field.type()));
getter.set_is_debuggable(false);
« no previous file with comments | « no previous file | tests/co19/co19-kernel.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698