Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issue 2536603003: Some PannerOptions dictionary members should be doubles (Closed)

Created:
4 years ago by Raymond Toy
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Some PannerOptions dictionary members should be doubles Some of the dictionary members were incorrectly declared to be floats when they should have been doubles. The corresponding attributes themselves are doubles so the members should match. See https://webaudio.github.io/web-audio-api/#panneroptions BUG=666471 TEST=constructor/panner.html updated Review-Url: https://codereview.chromium.org/2508733006 Cr-Commit-Position: refs/heads/master@{#433217} (cherry picked from commit a4eae706d4f07f9d297ce0f8d8cbc2bf07618598) Committed: https://chromium.googlesource.com/chromium/src/+/6490317e95b58a3068a7c123904afaf4eb7a5467

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -24 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/constructor/panner.html View 2 chunks +24 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/PannerOptions.idl View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Raymond Toy
4 years ago (2016-11-28 19:33:44 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6490317e95b58a3068a7c123904afaf4eb7a5467 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698