Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 2508733006: Some PannerOptions dictionary members should be doubles (Closed)

Created:
4 years, 1 month ago by Raymond Toy
Modified:
4 years, 1 month ago
Reviewers:
tkent, hongchan
CC:
blink-reviews, chromium-reviews, haraken, hongchan, Raymond Toy
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Some PannerOptions dictionary members should be doubles Some of the dictionary members were incorrectly declared to be floats when they should have been doubles. The corresponding attributes themselves are doubles so the members should match. See https://webaudio.github.io/web-audio-api/#panneroptions BUG=666471 TEST=constructor/panner.html updated Committed: https://crrev.com/a4eae706d4f07f9d297ce0f8d8cbc2bf07618598 Cr-Commit-Position: refs/heads/master@{#433217}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -24 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/constructor/panner.html View 2 chunks +24 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/PannerOptions.idl View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Raymond Toy
PTAL. tkent: PTAL as API Owner. This is a typo in our implementation of the ...
4 years, 1 month ago (2016-11-17 22:29:45 UTC) #5
tkent
lgtm
4 years, 1 month ago (2016-11-17 22:36:13 UTC) #6
hongchan
lgtm
4 years, 1 month ago (2016-11-17 22:58:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2508733006/1
4 years, 1 month ago (2016-11-18 15:25:32 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 16:41:08 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 16:43:31 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a4eae706d4f07f9d297ce0f8d8cbc2bf07618598
Cr-Commit-Position: refs/heads/master@{#433217}

Powered by Google App Engine
This is Rietveld 408576698