Issue 25366002: Writing to testName and reading its size isn't thread safe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25366002: Writing to testName and reading its size isn't thread safe. (Closed)

Created:
7 years, 2 months ago by mtklein

Modified:
7 years, 2 months ago

Reviewers:
caryclark

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Writing to testName and reading its size isn't thread safe, TSAN reminds us. Guarding it into a no-op makes it safe. Looks like this is only used for debugging, presumably singlethreaded? BUG= Committed: http://code.google.com/p/skia/source/detail?r=11562

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	tests/PathOpsExtendedTest.cpp	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/25366002/1

7 years, 2 months ago (2013-10-01 13:02:45 UTC) #3

Message was sent while issue was closed.

Change committed as 11562

Expand Messages | Collapse Messages