Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1563)

Unified Diff: tests/PathOpsExtendedTest.cpp

Issue 25366002: Writing to testName and reading its size isn't thread safe. (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/PathOpsExtendedTest.cpp
diff --git a/tests/PathOpsExtendedTest.cpp b/tests/PathOpsExtendedTest.cpp
index efee0fcb42e10de341b4d9a79ec4deac488a3a2e..c32bfa1e061f5a4549e2c3735dc1b5639c5ea105 100644
--- a/tests/PathOpsExtendedTest.cpp
+++ b/tests/PathOpsExtendedTest.cpp
@@ -632,6 +632,7 @@ int initializeTests(skiatest::Reporter* reporter, const char* test) {
SkPathOpsDebug::gMaxWindSum = 4;
SkPathOpsDebug::gMaxWindValue = 4;
#endif
+#if DEBUG_SHOW_TEST_NAME
testName = test;
size_t testNameSize = strlen(test);
SkFILEStream inFile("../../experimental/Intersection/op.htm");
@@ -648,6 +649,7 @@ int initializeTests(skiatest::Reporter* reporter, const char* test) {
testNumber = atoi(numLoc) + 1;
}
}
+#endif
return reporter->allowThreaded() ? SkThreadPool::kThreadPerCore : 1;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698