Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Unified Diff: components/offline_pages/offline_page_model_impl.h

Issue 2536573003: [Offline pages] Preventing GetPagesMatchingQuery from running before model is loaded (Closed)
Patch Set: Adding a test for public method GetPagesMatchingQuery Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_page_model_impl.h
diff --git a/components/offline_pages/offline_page_model_impl.h b/components/offline_pages/offline_page_model_impl.h
index c88dafa6cff53b26fa39df2b1e74baf6f8075c3f..9b0f123a6dbb8adab7f5e94d0644eb5877d1a207 100644
--- a/components/offline_pages/offline_page_model_impl.h
+++ b/components/offline_pages/offline_page_model_impl.h
@@ -129,15 +129,12 @@ class OfflinePageModelImpl : public OfflinePageModel, public KeyedService {
// Callback for ensuring archive directory is created.
void OnEnsureArchivesDirCreatedDone(const base::TimeTicks& start_time);
- void CheckPagesExistOfflineAfterLoadDone(
- const std::set<GURL>& urls,
- const CheckPagesExistOfflineCallback& callback);
+ void GetPagesMatchingQueryWhenLoadDone(
+ std::unique_ptr<OfflinePageModelQuery> query,
+ const MultipleOfflinePageItemCallback& callback);
void GetOfflineIdsForClientIdWhenLoadDone(
const ClientId& client_id,
const MultipleOfflineIdCallback& callback) const;
- void GetPageByOfflineIdWhenLoadDone(
- int64_t offline_id,
- const SingleOfflinePageItemCallback& callback) const;
const std::vector<int64_t> MaybeGetOfflineIdsForClientId(
const ClientId& client_id) const;
void GetPagesByURLWhenLoadDone(

Powered by Google App Engine
This is Rietveld 408576698