Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2536373007: [wasm] Make DisassembleFunction a method of WasmCompiledModule (Closed)

Created:
4 years ago by Clemens Hammacher
Modified:
4 years ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Make DisassembleFunction a method of WasmCompiledModule Before, it was a method in wasm namespace, and received a Handle<WasmCompiledModule>. As it does not allocate on the heap, we can just make it a non-static method on WasmCompiledModule. R=titzer@chromium.org Committed: https://crrev.com/4e55cbf757478d6389719f327f41131e72fe39ea Cr-Commit-Position: refs/heads/master@{#41429}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -35 lines) Patch
M src/api.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/wasm/wasm-module.h View 1 chunk +0 lines, -8 lines 0 comments Download
M src/wasm/wasm-module.cc View 2 chunks +0 lines, -26 lines 0 comments Download
M src/wasm/wasm-objects.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/wasm/wasm-objects.cc View 2 chunks +22 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
Clemens Hammacher
4 years ago (2016-12-01 13:19:09 UTC) #3
titzer
On 2016/12/01 13:19:09, Clemens Hammacher wrote: lgtm
4 years ago (2016-12-01 13:24:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536373007/1
4 years ago (2016-12-01 13:42:32 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 13:44:09 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-01 13:44:45 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4e55cbf757478d6389719f327f41131e72fe39ea
Cr-Commit-Position: refs/heads/master@{#41429}

Powered by Google App Engine
This is Rietveld 408576698