[inspector] Introduce debug::WasmScript

[inspector] Introduce debug::WasmScript

*and* report all "virtual" wasm scripts right when the wasm script is
registered at the inspector.

WasmScript is a subtype of Script, with the cast checking that it is
actually a wasm script.
This layout makes it quite easy to implement functionality that is only
available for wasm scripts, and allows to later directly use the
WasmCompiledModule instead of the i::Script for backing the
debug::WasmScript. We might also add virtual methods to
provide different implementations for GetSourcePosition, Source and
others.

DisassembleWasmFunction now also becomes a method of this class instead
of a static function on the DebugInterface.

The WasmTranslation now uses the new WasmScript type instead of the
Script wrapper, and also registers all virtual wasm scripts immediately
when the wasm script is made public to the inspector (when the wasm
module is created).

R=yangguo@chromium.org,dgozman@chromium.org,titzer@chromium.org
BUG=chromium:613110, chromium:659715
Committed: https://crrev.com/12cdb31b2fd1a51843e0b4753af15e4488a67a3e
Cr-Commit-Position: refs/heads/master@{#41519}

[Clemens Hammacher, 2016-12-01 15:21:00]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 15:21:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 15:47:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 15:47:04]

Dry run: This issue passed the CQ dry run.

[Clemens Hammacher, 2016-12-01 17:02:33]

Description was changed from

==========
dev
==========

to

==========
[inspector] Introduce DebugInterface::WasmScript

*and* report all "virtual" wasm scripts right when the wasm script is
registered at the inspector.

WasmScript is a subtype of Script, with the cast checking that it is
actually a wasm script.
This layout makes it quite easy to implement functionality that is only
available for wasm scripts, and allows to later directly use the
WasmCompiledModule instead of the i::Script for backing the
DebugInterface::WasmScript.

DisassembleWasmFunction now also becomes a method of this class instead
of a static function on the DebugInterface.

The WasmTranslation now uses the new WasmScript type instead of the
Script wrapper, and also registers all virtual wasm scripts immediately
when the wasm script is made public to the inspector (when the wasm
module is created).

R=yangguo@chromium.org,dgozman@chromium.org,titzer@chromium.org
BUG=chromium:613110
==========

[Clemens Hammacher, 2016-12-01 17:02:33]

clemensh@chromium.org changed reviewers:
+ dgozman@chromium.org, titzer@chromium.org, yangguo@chromium.org

[Clemens Hammacher, 2016-12-01 17:26:49]

Description was changed from

==========
[inspector] Introduce DebugInterface::WasmScript

*and* report all "virtual" wasm scripts right when the wasm script is
registered at the inspector.

WasmScript is a subtype of Script, with the cast checking that it is
actually a wasm script.
This layout makes it quite easy to implement functionality that is only
available for wasm scripts, and allows to later directly use the
WasmCompiledModule instead of the i::Script for backing the
DebugInterface::WasmScript.

DisassembleWasmFunction now also becomes a method of this class instead
of a static function on the DebugInterface.

The WasmTranslation now uses the new WasmScript type instead of the
Script wrapper, and also registers all virtual wasm scripts immediately
when the wasm script is made public to the inspector (when the wasm
module is created).

R=yangguo@chromium.org,dgozman@chromium.org,titzer@chromium.org
BUG=chromium:613110
==========

to

==========
[inspector] Introduce DebugInterface::WasmScript

*and* report all "virtual" wasm scripts right when the wasm script is
registered at the inspector.

WasmScript is a subtype of Script, with the cast checking that it is
actually a wasm script.
This layout makes it quite easy to implement functionality that is only
available for wasm scripts, and allows to later directly use the
WasmCompiledModule instead of the i::Script for backing the
DebugInterface::WasmScript. We might also add virtual methods to
provide different implementations for GetSourcePosition, Source and
others.

DisassembleWasmFunction now also becomes a method of this class instead
of a static function on the DebugInterface.

The WasmTranslation now uses the new WasmScript type instead of the
Script wrapper, and also registers all virtual wasm scripts immediately
when the wasm script is made public to the inspector (when the wasm
module is created).

R=yangguo@chromium.org,dgozman@chromium.org,titzer@chromium.org
BUG=chromium:613110
==========

[dgozman, 2016-12-02 00:52:01]

lgtm

https://codereview.chromium.org/2531163010/diff/1/src/inspector/v8-debugger-a...
File src/inspector/v8-debugger-agent-impl.cc (right):

https://codereview.chromium.org/2531163010/diff/1/src/inspector/v8-debugger-a...
src/inspector/v8-debugger-agent-impl.cc:528: if
(m_scripts.count(breakpoint.script_id) == 0) {
Do we need this now?

https://codereview.chromium.org/2531163010/diff/1/test/inspector/debugger/was...
File test/inspector/debugger/wasm-scripts-expected.txt (right):

https://codereview.chromium.org/2531163010/diff/1/test/inspector/debugger/was...
test/inspector/debugger/wasm-scripts-expected.txt:2: Script #0 parsed. URL:
If you use //# sourceURL=... comment, these will get urls as well which would be
nice.

[Clemens Hammacher, 2016-12-02 09:22:30]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 09:22:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Clemens Hammacher, 2016-12-02 09:23:47]

https://codereview.chromium.org/2531163010/diff/1/src/inspector/v8-debugger-a...
File src/inspector/v8-debugger-agent-impl.cc (right):

https://codereview.chromium.org/2531163010/diff/1/src/inspector/v8-debugger-a...
src/inspector/v8-debugger-agent-impl.cc:528: if
(m_scripts.count(breakpoint.script_id) == 0) {
On 2016/12/02 at 00:52:01, dgozman wrote:
> Do we need this now?

No, this check is wrong now. I removed it.

https://codereview.chromium.org/2531163010/diff/1/test/inspector/debugger/was...
File test/inspector/debugger/wasm-scripts-expected.txt (right):

https://codereview.chromium.org/2531163010/diff/1/test/inspector/debugger/was...
test/inspector/debugger/wasm-scripts-expected.txt:2: Script #0 parsed. URL:
On 2016/12/02 at 00:52:01, dgozman wrote:
> If you use //# sourceURL=... comment, these will get urls as well which would
be nice.

Nice, thanks. Done!

[commit-bot: I haz the power, 2016-12-02 09:49:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 09:49:37]

Dry run: This issue passed the CQ dry run.

[titzer, 2016-12-02 09:52:36]

lgtm but deferring to Yang.

https://codereview.chromium.org/2531163010/diff/20001/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/2531163010/diff/20001/src/api.cc#newcode9110
src/api.cc:9110: int DebugInterface::WasmScript::NumFunction() const {
NumFunctions?

[Clemens Hammacher, 2016-12-02 10:18:40]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 10:18:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Clemens Hammacher, 2016-12-02 10:38:10]

https://codereview.chromium.org/2531163010/diff/20001/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/2531163010/diff/20001/src/api.cc#newcode9110
src/api.cc:9110: int DebugInterface::WasmScript::NumFunction() const {
On 2016/12/02 at 09:52:36, titzer wrote:
> NumFunctions?

Doh! Thanks.

[commit-bot: I haz the power, 2016-12-02 10:47:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 10:47:10]

Dry run: This issue passed the CQ dry run.

[Clemens Hammacher, 2016-12-02 17:10:37]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 17:10:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 17:40:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 17:40:25]

Dry run: This issue passed the CQ dry run.

[kozy, 2016-12-02 18:13:49]

kozyatinskiy@chromium.org changed reviewers:
+ kozyatinskiy@chromium.org

[kozy, 2016-12-02 18:13:50]

lgtm

https://codereview.chromium.org/2531163010/diff/60001/test/inspector/debugger...
File test/inspector/debugger/wasm-scripts.js (right):

https://codereview.chromium.org/2531163010/diff/60001/test/inspector/debugger...
test/inspector/debugger/wasm-scripts.js:51: InspectorTest.log("Script #" +
num_scripts + " parsed. URL: " + url);
Can we request script content here and dump it as well?

[Clemens Hammacher, 2016-12-02 18:22:04]

Description was changed from

==========
[inspector] Introduce DebugInterface::WasmScript

*and* report all "virtual" wasm scripts right when the wasm script is
registered at the inspector.

WasmScript is a subtype of Script, with the cast checking that it is
actually a wasm script.
This layout makes it quite easy to implement functionality that is only
available for wasm scripts, and allows to later directly use the
WasmCompiledModule instead of the i::Script for backing the
DebugInterface::WasmScript. We might also add virtual methods to
provide different implementations for GetSourcePosition, Source and
others.

DisassembleWasmFunction now also becomes a method of this class instead
of a static function on the DebugInterface.

The WasmTranslation now uses the new WasmScript type instead of the
Script wrapper, and also registers all virtual wasm scripts immediately
when the wasm script is made public to the inspector (when the wasm
module is created).

R=yangguo@chromium.org,dgozman@chromium.org,titzer@chromium.org
BUG=chromium:613110
==========

to

==========
[inspector] Introduce DebugInterface::WasmScript

*and* report all "virtual" wasm scripts right when the wasm script is
registered at the inspector.

WasmScript is a subtype of Script, with the cast checking that it is
actually a wasm script.
This layout makes it quite easy to implement functionality that is only
available for wasm scripts, and allows to later directly use the
WasmCompiledModule instead of the i::Script for backing the
DebugInterface::WasmScript. We might also add virtual methods to
provide different implementations for GetSourcePosition, Source and
others.

DisassembleWasmFunction now also becomes a method of this class instead
of a static function on the DebugInterface.

The WasmTranslation now uses the new WasmScript type instead of the
Script wrapper, and also registers all virtual wasm scripts immediately
when the wasm script is made public to the inspector (when the wasm
module is created).

R=yangguo@chromium.org,dgozman@chromium.org,titzer@chromium.org
BUG=chromium:613110,chromium:659715
==========

[Yang, 2016-12-05 18:59:04]

lgtm.

[Clemens Hammacher, 2016-12-06 12:36:36]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 12:36:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Clemens Hammacher, 2016-12-06 12:53:17]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 12:53:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Clemens Hammacher, 2016-12-06 13:08:39]

Description was changed from

==========
[inspector] Introduce DebugInterface::WasmScript

*and* report all "virtual" wasm scripts right when the wasm script is
registered at the inspector.

WasmScript is a subtype of Script, with the cast checking that it is
actually a wasm script.
This layout makes it quite easy to implement functionality that is only
available for wasm scripts, and allows to later directly use the
WasmCompiledModule instead of the i::Script for backing the
DebugInterface::WasmScript. We might also add virtual methods to
provide different implementations for GetSourcePosition, Source and
others.

DisassembleWasmFunction now also becomes a method of this class instead
of a static function on the DebugInterface.

The WasmTranslation now uses the new WasmScript type instead of the
Script wrapper, and also registers all virtual wasm scripts immediately
when the wasm script is made public to the inspector (when the wasm
module is created).

R=yangguo@chromium.org,dgozman@chromium.org,titzer@chromium.org
BUG=chromium:613110,chromium:659715
==========

to

==========
[inspector] Introduce debug::WasmScript

*and* report all "virtual" wasm scripts right when the wasm script is
registered at the inspector.

WasmScript is a subtype of Script, with the cast checking that it is
actually a wasm script.
This layout makes it quite easy to implement functionality that is only
available for wasm scripts, and allows to later directly use the
WasmCompiledModule instead of the i::Script for backing the
DebugInterface::WasmScript. We might also add virtual methods to
provide different implementations for GetSourcePosition, Source and
others.

DisassembleWasmFunction now also becomes a method of this class instead
of a static function on the DebugInterface.

The WasmTranslation now uses the new WasmScript type instead of the
Script wrapper, and also registers all virtual wasm scripts immediately
when the wasm script is made public to the inspector (when the wasm
module is created).

R=yangguo@chromium.org,dgozman@chromium.org,titzer@chromium.org
BUG=chromium:613110,chromium:659715
==========

[Clemens Hammacher, 2016-12-06 13:09:07]

Description was changed from

==========
[inspector] Introduce debug::WasmScript

*and* report all "virtual" wasm scripts right when the wasm script is
registered at the inspector.

WasmScript is a subtype of Script, with the cast checking that it is
actually a wasm script.
This layout makes it quite easy to implement functionality that is only
available for wasm scripts, and allows to later directly use the
WasmCompiledModule instead of the i::Script for backing the
DebugInterface::WasmScript. We might also add virtual methods to
provide different implementations for GetSourcePosition, Source and
others.

DisassembleWasmFunction now also becomes a method of this class instead
of a static function on the DebugInterface.

The WasmTranslation now uses the new WasmScript type instead of the
Script wrapper, and also registers all virtual wasm scripts immediately
when the wasm script is made public to the inspector (when the wasm
module is created).

R=yangguo@chromium.org,dgozman@chromium.org,titzer@chromium.org
BUG=chromium:613110,chromium:659715
==========

to

==========
[inspector] Introduce debug::WasmScript

*and* report all "virtual" wasm scripts right when the wasm script is
registered at the inspector.

WasmScript is a subtype of Script, with the cast checking that it is
actually a wasm script.
This layout makes it quite easy to implement functionality that is only
available for wasm scripts, and allows to later directly use the
WasmCompiledModule instead of the i::Script for backing the
debug::WasmScript. We might also add virtual methods to
provide different implementations for GetSourcePosition, Source and
others.

DisassembleWasmFunction now also becomes a method of this class instead
of a static function on the DebugInterface.

The WasmTranslation now uses the new WasmScript type instead of the
Script wrapper, and also registers all virtual wasm scripts immediately
when the wasm script is made public to the inspector (when the wasm
module is created).

R=yangguo@chromium.org,dgozman@chromium.org,titzer@chromium.org
BUG=chromium:613110,chromium:659715
==========

[commit-bot: I haz the power, 2016-12-06 13:16:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 13:16:56]

Dry run: This issue passed the CQ dry run.

[Clemens Hammacher, 2016-12-06 13:18:03]

The CQ bit was checked by clemensh@chromium.org

[Clemens Hammacher, 2016-12-06 13:18:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
dgozman@chromium.org, titzer@chromium.org, kozyatinskiy@chromium.org,
yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2531163010/#ps100001
(title: "Fix expected output")

[commit-bot: I haz the power, 2016-12-06 13:18:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Clemens Hammacher, 2016-12-06 13:18:20]

https://codereview.chromium.org/2531163010/diff/60001/test/inspector/debugger...
File test/inspector/debugger/wasm-scripts.js (right):

https://codereview.chromium.org/2531163010/diff/60001/test/inspector/debugger...
test/inspector/debugger/wasm-scripts.js:51: InspectorTest.log("Script #" +
num_scripts + " parsed. URL: " + url);
On 2016/12/02 at 18:13:50, kozyatinskiy wrote:
> Can we request script content here and dump it as well?

Done.

[commit-bot: I haz the power, 2016-12-06 13:20:08]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1481030283181670,
"parent_rev": "9eb8482ee7101db383528af1e07db96c1ef379ca", "commit_rev":
"8e43bf214eb1c527994a1cb8cb72cb785e1e98f3"}

[commit-bot: I haz the power, 2016-12-06 13:20:16]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-12-06 13:20:44]

Description was changed from

==========
[inspector] Introduce debug::WasmScript

*and* report all "virtual" wasm scripts right when the wasm script is
registered at the inspector.

WasmScript is a subtype of Script, with the cast checking that it is
actually a wasm script.
This layout makes it quite easy to implement functionality that is only
available for wasm scripts, and allows to later directly use the
WasmCompiledModule instead of the i::Script for backing the
debug::WasmScript. We might also add virtual methods to
provide different implementations for GetSourcePosition, Source and
others.

DisassembleWasmFunction now also becomes a method of this class instead
of a static function on the DebugInterface.

The WasmTranslation now uses the new WasmScript type instead of the
Script wrapper, and also registers all virtual wasm scripts immediately
when the wasm script is made public to the inspector (when the wasm
module is created).

R=yangguo@chromium.org,dgozman@chromium.org,titzer@chromium.org
BUG=chromium:613110,chromium:659715
==========

to

==========
[inspector] Introduce debug::WasmScript

*and* report all "virtual" wasm scripts right when the wasm script is
registered at the inspector.

WasmScript is a subtype of Script, with the cast checking that it is
actually a wasm script.
This layout makes it quite easy to implement functionality that is only
available for wasm scripts, and allows to later directly use the
WasmCompiledModule instead of the i::Script for backing the
debug::WasmScript. We might also add virtual methods to
provide different implementations for GetSourcePosition, Source and
others.

DisassembleWasmFunction now also becomes a method of this class instead
of a static function on the DebugInterface.

The WasmTranslation now uses the new WasmScript type instead of the
Script wrapper, and also registers all virtual wasm scripts immediately
when the wasm script is made public to the inspector (when the wasm
module is created).

R=yangguo@chromium.org,dgozman@chromium.org,titzer@chromium.org
BUG=chromium:613110,chromium:659715

Committed: https://crrev.com/12cdb31b2fd1a51843e0b4753af15e4488a67a3e
Cr-Commit-Position: refs/heads/master@{#41519}
==========

[commit-bot: I haz the power, 2016-12-06 13:20:45]

Patchset 6 (id:??) landed as
https://crrev.com/12cdb31b2fd1a51843e0b4753af15e4488a67a3e
Cr-Commit-Position: refs/heads/master@{#41519}