Pass in the prototype to CreateApiFunction rather than setting it on the result.

Pass in the prototype to CreateApiFunction rather than setting it on the result.

BUG=
R=ishell@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=21066

[Toon Verwaest, 2014-04-25 13:35:14]

PTAL.
Another step towards immediately making the prototype read-only rather than in
Instantiate after CreateApiFunction.

[Igor Sheludko, 2014-04-28 15:00:38]

lgtm with suggestion:

https://codereview.chromium.org/253603003/diff/1/src/factory.cc
File src/factory.cc (right):

https://codereview.chromium.org/253603003/diff/1/src/factory.cc#newcode2120
src/factory.cc:2120: if (obj->remove_prototype()) return result;
Does it make sense to put ASSERT(result->shared()->IsApiFunction()); before
return here?

[Toon Verwaest, 2014-04-29 09:41:13]

Done. Landing.

https://codereview.chromium.org/253603003/diff/1/src/factory.cc
File src/factory.cc (right):

https://codereview.chromium.org/253603003/diff/1/src/factory.cc#newcode2120
src/factory.cc:2120: if (obj->remove_prototype()) return result;
On 2014/04/28 15:00:38, Igor Sheludko wrote:
> Does it make sense to put ASSERT(result->shared()->IsApiFunction()); before
> return here?

Done.

[Toon Verwaest, 2014-04-29 17:48:17]

Committed patchset #1 manually as r21066 (presubmit successful).