Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 2536013002: Fix implicit channel layout configurations at non-1.0 playback rates. (Closed)

Created:
4 years ago by DaleCurtis
Modified:
4 years ago
Reviewers:
chcunningham, alokp
CC:
avayvod+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org, imcheng+watch_chromium.org, isheriff+watch_chromium.org, jasonroberts+watch_google.com, miu+watch_chromium.org, posciak+watch_chromium.org, xjz+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix implicit channel layout configurations at non-1.0 playback rates. Change http://crrev.com/21d17ca06e742cbfdcaaa54e0f4964248e3fbfff incorrectly assumed the input channel layout never changes. This patch fixes that issue by allowing the channel mask to change as layouts change. BUG=666813 TEST=updated unittests TEST=http://storage.googleapis.com/chcunningham-chrome-shared/534301/aac_test.html Committed: https://crrev.com/c242c3a3b9242f63aa079ec10442488d1a6916cb Cr-Commit-Position: refs/heads/master@{#434868}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -89 lines) Patch
M media/cast/test/fake_media_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/audio_renderer_algorithm.h View 3 chunks +15 lines, -5 lines 0 comments Download
M media/filters/audio_renderer_algorithm.cc View 4 chunks +29 lines, -20 lines 0 comments Download
M media/filters/audio_renderer_algorithm_unittest.cc View 5 chunks +20 lines, -6 lines 0 comments Download
M media/renderers/audio_renderer_impl.h View 2 chunks +7 lines, -2 lines 0 comments Download
M media/renderers/audio_renderer_impl.cc View 5 chunks +58 lines, -26 lines 0 comments Download
M media/renderers/audio_renderer_impl_unittest.cc View 7 chunks +55 lines, -29 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
DaleCurtis
+alokp for media/cast/test, chris for everything else.
4 years ago (2016-11-28 23:21:12 UTC) #2
alokp
chromecast/ lgtm
4 years ago (2016-11-28 23:26:35 UTC) #3
chcunningham
lgtm
4 years ago (2016-11-29 01:23:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536013002/1
4 years ago (2016-11-29 01:25:54 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 03:29:00 UTC) #9
commit-bot: I haz the power
4 years ago (2016-11-29 03:33:09 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c242c3a3b9242f63aa079ec10442488d1a6916cb
Cr-Commit-Position: refs/heads/master@{#434868}

Powered by Google App Engine
This is Rietveld 408576698