Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: media/renderers/audio_renderer_impl.h

Issue 2536013002: Fix implicit channel layout configurations at non-1.0 playback rates. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/audio_renderer_algorithm_unittest.cc ('k') | media/renderers/audio_renderer_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/renderers/audio_renderer_impl.h
diff --git a/media/renderers/audio_renderer_impl.h b/media/renderers/audio_renderer_impl.h
index 504a46b6fb4fc1a95bfb36cf1c705df742378f34..d8763370664056b0a4c15484222addfa385f51e2 100644
--- a/media/renderers/audio_renderer_impl.h
+++ b/media/renderers/audio_renderer_impl.h
@@ -196,6 +196,10 @@ class MEDIA_EXPORT AudioRendererImpl
// Updates |buffering_state_| and fires |buffering_state_cb_|.
void SetBufferingState_Locked(BufferingState buffering_state);
+ // Configure's the channel mask for |algorithm_|. Must be called if the layout
+ // changes. Expect the layout in |last_decoded_channel_layout_|.
+ void ConfigureChannelMask();
+
scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
std::unique_ptr<AudioBufferConverter> buffer_converter_;
@@ -234,8 +238,9 @@ class MEDIA_EXPORT AudioRendererImpl
// sample rate changes due to implicit AAC configuration change.
int last_decoded_sample_rate_;
- // Indicates which channels are muted and can be ignored by the algorithm.
- std::vector<bool> channel_mask_;
+ // Similar to |last_decoded_sample_rate_|, used to configure the channel mask
+ // given to the |algorithm_| for efficient playback rate changes.
+ ChannelLayout last_decoded_channel_layout_;
// After Initialize() has completed, all variables below must be accessed
// under |lock_|. ------------------------------------------------------------
« no previous file with comments | « media/filters/audio_renderer_algorithm_unittest.cc ('k') | media/renderers/audio_renderer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698