[Findit] Add two more gtest command line switches.

[Findit] Add two more gtest command line switches.

BUG=666115, 666110
R=chanli, lijeffrey

Committed: https://chromium.googlesource.com/infra/infra/+/1cb10c5b2e7822c95567b66de85edf9805e401c2

[stgao, 2016-11-29 00:18:07]

ptal

[chanli, 2016-11-29 05:04:48]

LGTM with one question

https://codereview.chromium.org/2535953003/diff/1/appengine/findit/waterfall/...
File appengine/findit/waterfall/trigger_base_swarming_task_pipeline.py (right):

https://codereview.chromium.org/2535953003/diff/1/appengine/findit/waterfall/...
appengine/findit/waterfall/trigger_base_swarming_task_pipeline.py:60:
new_request.extra_args.append('--gtest_also_run_disabled_tests')
Question: for more general cases, shouldn't we stop the swarming task when we
found the test has been disabled?

[lijeffrey, 2016-11-29 05:51:31]

lgtm

https://codereview.chromium.org/2535953003/diff/1/appengine/findit/waterfall/...
File appengine/findit/waterfall/trigger_base_swarming_task_pipeline.py (right):

https://codereview.chromium.org/2535953003/diff/1/appengine/findit/waterfall/...
appengine/findit/waterfall/trigger_base_swarming_task_pipeline.py:46: not
a.startswith('--gtest_filter') and
So I'm not actually familiar with these flags, where are they documented/defined
for further reading?

[stgao, 2016-11-29 07:38:53]

https://codereview.chromium.org/2535953003/diff/1/appengine/findit/waterfall/...
File appengine/findit/waterfall/trigger_base_swarming_task_pipeline.py (right):

https://codereview.chromium.org/2535953003/diff/1/appengine/findit/waterfall/...
appengine/findit/waterfall/trigger_base_swarming_task_pipeline.py:46: not
a.startswith('--gtest_filter') and
On 2016/11/29 05:51:30, lijeffrey wrote:
> So I'm not actually familiar with these flags, where are they
documented/defined
> for further reading?

For gtest_filter, you may search on gtest documentation.
For test-launcher-filter-file, you may search it in the chromium codebase.

You may want to learn related switches/settings when you have a chance.

https://codereview.chromium.org/2535953003/diff/1/appengine/findit/waterfall/...
appengine/findit/waterfall/trigger_base_swarming_task_pipeline.py:60:
new_request.extra_args.append('--gtest_also_run_disabled_tests')
On 2016/11/29 05:04:48, chanli wrote:
> Question: for more general cases, shouldn't we stop the swarming task when we
> found the test has been disabled?

Two questions before I could answer your question :)
And I updated the description a little bit to make it more clear.

1. Is it possible to distinguish the cases you referred to from the cases
described here (the test got disabled before Findit runs any analysis)?
2. Why we should stop the swarming task? Is it just a skip of rerun at the
selected build? Will the analysis continue to run or just stop?

[stgao, 2016-11-29 07:38:58]

The CQ bit was checked by stgao@chromium.org

[stgao, 2016-11-29 07:38:58]

The patchset sent to the CQ was uploaded after l-g-t-m from chanli@chromium.org,
lijeffrey@chromium.org
Link to the patchset: https://codereview.chromium.org/2535953003/#ps20001
(title: "Update description of scenario.")

[commit-bot: I haz the power, 2016-11-29 07:39:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 07:54:01]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480405138076790,
"parent_rev": "a144a58910e49ecf03dd9bef1b3c8e3e1fd5d733", "commit_rev":
"1cb10c5b2e7822c95567b66de85edf9805e401c2"}

[commit-bot: I haz the power, 2016-11-29 07:54:05]

Description was changed from

==========
[Findit] Add two more gtest command line switches.

BUG=666115,666110
R=chanli, lijeffrey
==========

to

==========
[Findit] Add two more gtest command line switches.

BUG=666115,666110
R=chanli, lijeffrey

Committed:
https://chromium.googlesource.com/infra/infra/+/1cb10c5b2e7822c95567b66de85ed...
==========

[commit-bot: I haz the power, 2016-11-29 07:54:06]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/1cb10c5b2e7822c95567b66de85ed...

[chanli, 2016-11-29 17:52:32]

https://codereview.chromium.org/2535953003/diff/1/appengine/findit/waterfall/...
File appengine/findit/waterfall/trigger_base_swarming_task_pipeline.py (right):

https://codereview.chromium.org/2535953003/diff/1/appengine/findit/waterfall/...
appengine/findit/waterfall/trigger_base_swarming_task_pipeline.py:60:
new_request.extra_args.append('--gtest_also_run_disabled_tests')
On 2016/11/29 07:38:53, stgao (slow on Monday) wrote:
> On 2016/11/29 05:04:48, chanli wrote:
> > Question: for more general cases, shouldn't we stop the swarming task when
we
> > found the test has been disabled?
> 
> Two questions before I could answer your question :)
> And I updated the description a little bit to make it more clear.
> 
> 1. Is it possible to distinguish the cases you referred to from the cases
> described here (the test got disabled before Findit runs any analysis)?
> 2. Why we should stop the swarming task? Is it just a skip of rerun at the
> selected build? Will the analysis continue to run or just stop?

IIUC, we don't treat disabling a flaky test as a solution to flakiness, right?
If that's correct, I don't have further questions.

[stgao, 2016-11-29 18:09:36]

https://codereview.chromium.org/2535953003/diff/1/appengine/findit/waterfall/...
File appengine/findit/waterfall/trigger_base_swarming_task_pipeline.py (right):

https://codereview.chromium.org/2535953003/diff/1/appengine/findit/waterfall/...
appengine/findit/waterfall/trigger_base_swarming_task_pipeline.py:60:
new_request.extra_args.append('--gtest_also_run_disabled_tests')
On 2016/11/29 17:52:32, chanli wrote:
> On 2016/11/29 07:38:53, stgao (slow on Monday) wrote:
> > On 2016/11/29 05:04:48, chanli wrote:
> > > Question: for more general cases, shouldn't we stop the swarming task when
> we
> > > found the test has been disabled?
> > 
> > Two questions before I could answer your question :)
> > And I updated the description a little bit to make it more clear.
> > 
> > 1. Is it possible to distinguish the cases you referred to from the cases
> > described here (the test got disabled before Findit runs any analysis)?
> > 2. Why we should stop the swarming task? Is it just a skip of rerun at the
> > selected build? Will the analysis continue to run or just stop?
> 
> IIUC, we don't treat disabling a flaky test as a solution to flakiness, right?
> If that's correct, I don't have further questions.

No, disabling is just a temporary workaround.