Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1964)

Unified Diff: appengine/findit/waterfall/trigger_base_swarming_task_pipeline.py

Issue 2535953003: [Findit] Add two more gtest command line switches. (Closed)
Patch Set: Update description of scenario. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/waterfall/test/trigger_base_swarming_task_result_pipeline_test.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/waterfall/trigger_base_swarming_task_pipeline.py
diff --git a/appengine/findit/waterfall/trigger_base_swarming_task_pipeline.py b/appengine/findit/waterfall/trigger_base_swarming_task_pipeline.py
index f3401a2a41047b70e186efd095f2d7fdaf82f59a..f8dbfe1b3558814e2b2c3893ca0145f22d6e8639 100644
--- a/appengine/findit/waterfall/trigger_base_swarming_task_pipeline.py
+++ b/appengine/findit/waterfall/trigger_base_swarming_task_pipeline.py
@@ -40,12 +40,29 @@ class TriggerBaseSwarmingTaskPipeline(BasePipeline): # pragma: no cover.
new_request.idempotent = False
# Set the gtest_filter to run the given tests only.
- new_request.extra_args.append('--gtest_repeat=%s' % iterations)
- new_request.extra_args.append('--test-launcher-retry-limit=0')
+ # Remove existing test filter first.
new_request.extra_args = [
- a for a in new_request.extra_args if not a.startswith('--gtest_filter')
+ a for a in new_request.extra_args if (
+ not a.startswith('--gtest_filter') and
+ not a.startswith('--test-launcher-filter-file'))
]
new_request.extra_args.append('--gtest_filter=%s' % ':'.join(tests))
+ new_request.extra_args.append('--gtest_repeat=%s' % iterations)
+ new_request.extra_args.append('--test-launcher-retry-limit=0')
+
+ # Also rerun disabled tests. Scenario: the test was disabled before Findit
+ # runs any analysis. One possible case:
+ # 1. A gtest became flaky on CQ, but Findit was not automatically
+ # triggered to run any analysis because:
+ # * the test is not flaky enough
+ # * chromium-try-flakes has filed/updated too many bugs
+ # 2. The test got disabled, but no culprit was identified.
+ # 3. Some developer starts the investigation and requests Findit to
+ # analyze the flaky test.
+ # 4. Findit picks the latest Waterfall build of the matching configuration
+ # for the CQ build in which the flaky test is found.
+ # 5. In the picked Waterfall build, the test is already disabled.
+ new_request.extra_args.append('--gtest_also_run_disabled_tests')
# Remove the env setting for sharding.
sharding_settings = ['GTEST_SHARD_INDEX', 'GTEST_TOTAL_SHARDS']
« no previous file with comments | « appengine/findit/waterfall/test/trigger_base_swarming_task_result_pipeline_test.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698