Componentize EncryptedMediaMessageFilter and rename it CdmMessageFilter.

content/public/renderer/key_system_info.h

Index: content/public/renderer/key_system_info.h
diff --git a/content/public/renderer/key_system_info.h b/content/public/renderer/key_system_info.h
index 8eb2e573c4806e7e4fb1284bbe7929155628450c..72d18f138f915f0c4054f8d2402a59129b13300a 100644
--- a/content/public/renderer/key_system_info.h
+++ b/content/public/renderer/key_system_info.h
@@ -35,6 +35,13 @@ namespace content {
 struct CONTENT_EXPORT KeySystemInfo {
   explicit KeySystemInfo(const std::string& key_system);
   ~KeySystemInfo();
+  static KeySystemInfo Build(const char* key_system,

[ddorwin, 2014/04/28 18:47:45]

This violates the Content API design:
http://www.chromium.org/developers/content-module/content-api

[ycheo (away), 2014/04/29 00:49:52]

The content api design allows to have constructors.
Is it OK to convert this into the constructor?

[ddorwin, 2014/04/29 00:53:12]

If you were to put it in a constructor, then we can probably make some of the
values const, but then it's unclear why they aren't private and in a class,
which is not allowed.

xhwang was considering some changes here, so discuss with him.

Before making a decision here, let's see what happens when much of the code is
moved to components/.

+                             bool has_parent,
+                             const char* suffix,
+#if defined(ENABLE_PEPPER_CDMS)

[Tom Sepez, 2014/04/28 18:21:52]

nit: maybe just pass this as NULL in the !ENABLE_PEPPER_CDMS to avoid  the ifdef
in the middle of the method declaration.

+                             const char* pepper_type,
+#endif
+                             SupportedCodecs supported_codecs);
 
   std::string key_system;