Componentize EncryptedMediaMessageFilter and rename it CdmMessageFilter.

content/public/renderer/key_system_info.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_RENDERER_KEY_SYSTEM_INFO_H_
 #define CONTENT_PUBLIC_RENDERER_KEY_SYSTEM_INFO_H_
 
 #include <map>
 #include <string>
 
@@ skipping 17 matching lines @@
 //    be an abstract key system.
 //    As an example, "com.example" is the parent of "com.example.foo".
 
 namespace content {
 
 // Contains information about an EME key system as well as how to instantiate
 // the corresponding CDM.
 struct CONTENT_EXPORT KeySystemInfo {
   explicit KeySystemInfo(const std::string& key_system);
   ~KeySystemInfo();
+  static KeySystemInfo Build(const char* key_system,

[ddorwin, 2014/04/28 18:47:45]

This violates the Content API design:
http://www.chromium.org/developers/content-module/content-api

[ycheo (away), 2014/04/29 00:49:52]

The content api design allows to have constructors.
Is it OK to convert this into the constructor?

[ddorwin, 2014/04/29 00:53:12]

If you were to put it in a constructor, then we can probably make some of the
values const, but then it's unclear why they aren't private and in a class,
which is not allowed.

xhwang was considering some changes here, so discuss with him.

Before making a decision here, let's see what happens when much of the code is
moved to components/.

+                             bool has_parent,
+                             const char* suffix,
+#if defined(ENABLE_PEPPER_CDMS)

[Tom Sepez, 2014/04/28 18:21:52]

nit: maybe just pass this as NULL in the !ENABLE_PEPPER_CDMS to avoid  the ifdef
in the middle of the method declaration.

+                             const char* pepper_type,
+#endif
+                             SupportedCodecs supported_codecs);
 
   std::string key_system;
 
   // Specifies codecs supported by |key_system|.
   SupportedCodecs supported_codecs;
 
   // A hierarchical parent for |key_system|. This value can be used to check
   // supported types but cannot be used to instantiate a MediaKeys object.
   // Only one parent key system is currently supported per concrete key system.
   std::string parent_key_system;
 
   // The following indicate how the corresponding CDM should be instantiated.
   bool use_aes_decryptor;
 #if defined(ENABLE_PEPPER_CDMS)
   std::string pepper_type;
 #endif
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_RENDERER_KEY_SYSTEM_INFO_H_