chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java - Issue 2535853002: Clean up UI WebContents when destroying VR Shell.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

Issue 2535853002: Clean up UI WebContents when destroying VR Shell. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

index fae9c8cca1c4a2fc7f95f68b7d5a5c00d60fdd8f..9e054ec8ee53cf125cdf5080fe87cbe5be2a8285 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

@@ -317,6 +317,7 @@ public class VrShellImpl extends GvrLayout implements GLSurfaceView.Renderer, Vr

mUiFrameListener.mSurfaceTexture.release();

}

restoreContentWindow();

+ mUiContents.destroy();

}

@Override

« no previous file with comments | « no previous file | no next file » | no next file with comments »