[wasm][asm.js] Allow a function to be exported more than once.

[wasm][asm.js] Allow a function to be exported more than once.

Allow a function to be exported multiple times in a asm.js
module.
Remarkably, this had not been working before.

BUG=670057
R=titzer@chromium.org

Committed: https://crrev.com/71cc94dae36427decf9d4fe3b274ef3fb6959b55
Cr-Commit-Position: refs/heads/master@{#41416}

[bradnelson, 2016-12-01 08:59:00]

The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 08:59:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 09:13:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 09:13:54]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[bradnelson, 2016-12-01 09:21:17]

The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 09:21:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[titzer, 2016-12-01 09:22:25]

lgtm

https://codereview.chromium.org/2535723009/diff/1/src/wasm/wasm-module-builde...
File src/wasm/wasm-module-builder.cc (right):

https://codereview.chromium.org/2535723009/diff/1/src/wasm/wasm-module-builde...
src/wasm/wasm-module-builder.cc:145: name.start(), name.start() + name.length(),
builder_->zone()));
There was a memcpy in the old code. Is that necessary still?

https://codereview.chromium.org/2535723009/diff/1/src/wasm/wasm-module-builder.h
File src/wasm/wasm-module-builder.h (right):

https://codereview.chromium.org/2535723009/diff/1/src/wasm/wasm-module-builde...
src/wasm/wasm-module-builder.h:163: ZoneVector<ZoneVector<char> >
exported_names_;
I think the space between the two > > is superfluous here. Surprised that
clang-format didn't get it.

[bradn, 2016-12-01 09:27:07]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[bradn, 2016-12-01 09:27:08]

https://codereview.chromium.org/2535723009/diff/1/src/wasm/wasm-module-builde...
File src/wasm/wasm-module-builder.cc (right):

https://codereview.chromium.org/2535723009/diff/1/src/wasm/wasm-module-builde...
src/wasm/wasm-module-builder.cc:145: name.start(), name.start() + name.length(),
builder_->zone()));
On 2016/12/01 09:22:24, titzer wrote:
> There was a memcpy in the old code. Is that necessary still?

No, the old code was sharing a single vector, which was wrong (assumes a single
name to export under).
This creates a new ZoneVector per alternate export name.

https://codereview.chromium.org/2535723009/diff/1/src/wasm/wasm-module-builder.h
File src/wasm/wasm-module-builder.h (right):

https://codereview.chromium.org/2535723009/diff/1/src/wasm/wasm-module-builde...
src/wasm/wasm-module-builder.h:163: ZoneVector<ZoneVector<char> >
exported_names_;
On 2016/12/01 09:22:25, titzer wrote:
> I think the space between the two > > is superfluous here. Surprised that
> clang-format didn't get it.

Done.

Me recalling bad old C++ compilers from the 90s that needed the space....:-(

[bradnelson, 2016-12-01 09:27:12]

The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 09:27:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bradn, 2016-12-01 09:28:41]

The CQ bit was unchecked by bradnelson@google.com

[bradn, 2016-12-01 09:28:41]

The CQ bit was checked by bradnelson@google.com

[bradn, 2016-12-01 09:28:42]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2535723009/#ps40001
(title: "fix")

[commit-bot: I haz the power, 2016-12-01 09:28:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bradn, 2016-12-01 09:44:31]

The CQ bit was checked by bradnelson@google.com

[bradn, 2016-12-01 09:44:31]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2535723009/#ps60001
(title: "fix")

[commit-bot: I haz the power, 2016-12-01 09:44:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 10:12:40]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1480585471307830,
"parent_rev": "9107f4b6912d3fd407f543acd664789c3137ea60", "commit_rev":
"8bdcad406dc95c367879312005d007581448b539"}

[commit-bot: I haz the power, 2016-12-01 10:12:44]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-01 10:13:10]

Description was changed from

==========
[wasm][asm.js] Allow a function to be exported more than once.

Allow a function to be exported multiple times in a asm.js
module.
Remarkably, this had not been working before.

BUG=670057
R=titzer@chromium.org
==========

to

==========
[wasm][asm.js] Allow a function to be exported more than once.

Allow a function to be exported multiple times in a asm.js
module.
Remarkably, this had not been working before.

BUG=670057
R=titzer@chromium.org

Committed: https://crrev.com/71cc94dae36427decf9d4fe3b274ef3fb6959b55
Cr-Commit-Position: refs/heads/master@{#41416}
==========

[commit-bot: I haz the power, 2016-12-01 10:13:11]

Patchset 4 (id:??) landed as
https://crrev.com/71cc94dae36427decf9d4fe3b274ef3fb6959b55
Cr-Commit-Position: refs/heads/master@{#41416}