Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2535663005: M55: pdfium: Fix inconsistent number of color components of ICC profile (Closed)

Created:
4 years ago by Oliver Chang
Modified:
4 years ago
Reviewers:
Lei Zhang, Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/chromium/2883
Project:
pdfium
Visibility:
Public.

Description

M55: pdfium: Fix inconsistent number of color components of ICC profile fx_codec_icc.cpp specify default number of color components as 3 for unknown profiles. However, lcms may know such profile with different number of components. The inconsistency may lead to array access violation. This CL uses cmsChannelsOf() from lcms to ensure consistency. And rejects unexpected number according to PDF spec. BUG=chromium:667694 Original-Review-Url: https://codereview.chromium.org/2522933002 (cherry picked from commit 89a2d92549d25df6786d53de5671eb141e1fd3e2) TBR=thestig@chromium.org,tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/f4145df3f36aeb10d78d6b4ba9f06ca2270e5e37

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -29 lines) Patch
M core/fxcodec/codec/fx_codec_icc.cpp View 3 chunks +9 lines, -29 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Oliver Chang
TBR, clean merge.
4 years ago (2016-11-28 23:44:00 UTC) #1
Oliver Chang
4 years ago (2016-11-28 23:46:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f4145df3f36aeb10d78d6b4ba9f06ca2270e5e37 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698