Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1369)

Issue 2522933002: pdfium: Fix inconsistent number of color components of ICC profile (Closed)

Created:
4 years ago by kcwu
Modified:
4 years ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com, dominickn
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

pdfium: Fix inconsistent number of color components of ICC profile fx_codec_icc.cpp specify default number of color components as 3 for unknown profiles. However, lcms may know such profile with different number of components. The inconsistency may lead to array access violation. This CL uses cmsChannelsOf() from lcms to ensure consistency. And rejects unexpected number according to PDF spec. BUG=chromium:667694 Committed: https://pdfium.googlesource.com/pdfium/+/89a2d92549d25df6786d53de5671eb141e1fd3e2

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -29 lines) Patch
M core/fxcodec/codec/fx_codec_icc.cpp View 3 chunks +9 lines, -29 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
kcwu
4 years ago (2016-11-22 19:15:07 UTC) #2
dsinclair
Did you test with the fuzz file from crbug.com/663240 ?
4 years ago (2016-11-22 19:20:14 UTC) #4
kcwu
On 2016/11/22 19:20:14, dsinclair wrote: > Did you test with the fuzz file from crbug.com/663240 ...
4 years ago (2016-11-22 19:25:12 UTC) #5
dsinclair
lgtm
4 years ago (2016-11-22 19:25:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2522933002/20001
4 years ago (2016-11-22 19:25:53 UTC) #8
commit-bot: I haz the power
4 years ago (2016-11-22 19:37:19 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/89a2d92549d25df6786d53de5671eb141e1f...

Powered by Google App Engine
This is Rietveld 408576698