ninja/mac: Create -iphoneos device builds for iOS ninja generator.

ninja/mac: Create -iphoneos device builds for iOS ninja generator.

For builds that have iOS targets, clone each configuration with an "-iphoneos"  that builds for armv7 ios devices.  Gyp authors no longer need to set target_arch=armv7, although that is still supported.

[justincohen, 2013-09-30 21:52:46]

I still have to add a unit test, but I wanted to run this by you before I get
too far along.  Thanks!

[justincohen, 2013-10-01 14:07:05]

Now with unit tests.  PTAL!

[Nico, 2013-10-04 05:11:10]

I think I like this approach.

Does this means that the <(GENERATOR) checks you have in your gyp files can go
away?

https://codereview.chromium.org/25355002/diff/32001/pylib/gyp/generator/ninja.py
File pylib/gyp/generator/ninja.py (right):

https://codereview.chromium.org/25355002/diff/32001/pylib/gyp/generator/ninja...
pylib/gyp/generator/ninja.py:2118: for config_name in
target_dict['configurations'].keys():
Omit ".keys()", iterating a dict iterates the keys.

…but you only use the key to get at the value, so maybe iterate over .values()?

https://codereview.chromium.org/25355002/diff/32001/pylib/gyp/generator/ninja...
pylib/gyp/generator/ninja.py:2120: settings = config.get('xcode_settings', None)
None is the default for get, you can omit it

– but if you use {} as default you don't need the "if settings" check in the
next line

https://codereview.chromium.org/25355002/diff/32001/pylib/gyp/generator/ninja...
pylib/gyp/generator/ninja.py:2130: new_config_name = config_name+'-iphoneos'
spaces around +

https://codereview.chromium.org/25355002/diff/32001/pylib/gyp/generator/ninja...
pylib/gyp/generator/ninja.py:2131: new_config_dict = copy.deepcopy(config)
How much does this slow down gyp?

https://codereview.chromium.org/25355002/diff/32001/pylib/gyp/generator/ninja...
pylib/gyp/generator/ninja.py:2138: def GenerateOutput(target_list, target_dicts,
data, params):
call xcode_emulation.CloneConfigurationsForDeviceAndEmulator(targets) here, and
move the remaining code in this cl into xcode_emulation. Add docstrings to your
new functions.

(the if statement should be in CloneConfigurationsForDeviceAndEmulator too)

[justincohen, 2013-10-04 13:51:51]

Yes, a bunch of the GENERATOR calls will go away.  Here's a sample, although I
can likely remove even more.  

https://codereview.chromium.org/25535004/diff/1/build/common.gypi

Thanks for the review. PTAL!

https://codereview.chromium.org/25355002/diff/32001/pylib/gyp/generator/ninja.py
File pylib/gyp/generator/ninja.py (right):

https://codereview.chromium.org/25355002/diff/32001/pylib/gyp/generator/ninja...
pylib/gyp/generator/ninja.py:2118: for config_name in
target_dict['configurations'].keys():
On 2013/10/04 05:11:10, Nico wrote:
> Omit ".keys()", iterating a dict iterates the keys.
> 
> …but you only use the key to get at the value, so maybe iterate over
.values()?

Done.

https://codereview.chromium.org/25355002/diff/32001/pylib/gyp/generator/ninja...
pylib/gyp/generator/ninja.py:2120: settings = config.get('xcode_settings', None)
On 2013/10/04 05:11:10, Nico wrote:
> None is the default for get, you can omit it
> 
> – but if you use {} as default you don't need the "if settings" check in the
> next line

Done.

https://codereview.chromium.org/25355002/diff/32001/pylib/gyp/generator/ninja...
pylib/gyp/generator/ninja.py:2130: new_config_name = config_name+'-iphoneos'
On 2013/10/04 05:11:10, Nico wrote:
> spaces around +

Done.

https://codereview.chromium.org/25355002/diff/32001/pylib/gyp/generator/ninja...
pylib/gyp/generator/ninja.py:2131: new_config_dict = copy.deepcopy(config)
For Chrome for iOS, GenerateOutput is called 736 times, and each deepcopy takes
about 0.0004, which adds up to about an extra 0.32 seconds.  So not much.

In the end it adds up to On 2013/10/04 05:11:10, Nico wrote:
> How much does this slow down gyp?

https://codereview.chromium.org/25355002/diff/32001/pylib/gyp/generator/ninja...
pylib/gyp/generator/ninja.py:2138: def GenerateOutput(target_list, target_dicts,
data, params):
On 2013/10/04 05:11:10, Nico wrote:
> call xcode_emulation.CloneConfigurationsForDeviceAndEmulator(targets) here,
and
> move the remaining code in this cl into xcode_emulation. Add docstrings to
your
> new functions.
> 
> (the if statement should be in CloneConfigurationsForDeviceAndEmulator too)

Done.

[Ami GONE FROM CHROMIUM, 2013-10-04 18:10:36]

<driveby>

Can you update the CL description with what .gyp authors should do to accomodate
this change?  I can't tell e.g. what will need to change in my workflow
(https://code.google.com/p/webrtc/source/browse/trunk/talk/app/webrtc/objc/README)
as a result of this CL.

[justincohen, 2013-10-04 18:20:50]

I added a comment explaining what will change, but this CL should be backwards
compatible, so nothing needs to change.  In a future CL when I remove a bunch of
the GENERATOR if's in build/common.gypi, you'll want to just use the
autogenerated -iphoneos folder instead of out_ios and out_sim.  Thanks for
reminding me, before I submit I'll run the followup CL by you first.

[Ami GONE FROM CHROMIUM, 2013-10-04 19:24:56]

Thanks Justin.  The key I missed before is that is creating new configurations,
not new targets (i.e. out/Debug-iphoneos/MyTarget, not
out/Debug/MyTarget-iphoneos).  
Meaningless LGTM :)

[Nico, 2013-10-04 19:35:07]

lgtm

https://codereview.chromium.org/25355002/diff/45001/pylib/gyp/xcode_emulation.py
File pylib/gyp/xcode_emulation.py (right):

https://codereview.chromium.org/25355002/diff/45001/pylib/gyp/xcode_emulation...
pylib/gyp/xcode_emulation.py:1194: 
python style guide says two blank lines between functions

https://codereview.chromium.org/25355002/diff/45001/pylib/gyp/xcode_emulation...
pylib/gyp/xcode_emulation.py:1195: def HasIOSTarget(targets):
this is module-private, start name with a _

https://codereview.chromium.org/25355002/diff/45001/pylib/gyp/xcode_emulation...
pylib/gyp/xcode_emulation.py:1201: if
settings.get('IPHONEOS_DEPLOYMENT_TARGET'):
If it fits in one line, go with

  if config.get('xcode_settings', {}).get('IPHONEOS_DEPLOYMENT_TARGET'):

https://codereview.chromium.org/25355002/diff/45001/pylib/gyp/xcode_emulation...
pylib/gyp/xcode_emulation.py:1206: def AddIOSDeviceConfigurations(targets):
Also add a _ in front of the name

[justincohen, 2013-10-04 19:42:40]

https://codereview.chromium.org/25355002/diff/45001/pylib/gyp/xcode_emulation.py
File pylib/gyp/xcode_emulation.py (right):

https://codereview.chromium.org/25355002/diff/45001/pylib/gyp/xcode_emulation...
pylib/gyp/xcode_emulation.py:1194: 
On 2013/10/04 19:35:07, Nico wrote:
> python style guide says two blank lines between functions

Done.

https://codereview.chromium.org/25355002/diff/45001/pylib/gyp/xcode_emulation...
pylib/gyp/xcode_emulation.py:1195: def HasIOSTarget(targets):
On 2013/10/04 19:35:07, Nico wrote:
> this is module-private, start name with a _

Done.

https://codereview.chromium.org/25355002/diff/45001/pylib/gyp/xcode_emulation...
pylib/gyp/xcode_emulation.py:1201: if
settings.get('IPHONEOS_DEPLOYMENT_TARGET'):
On 2013/10/04 19:35:07, Nico wrote:
> If it fits in one line, go with
> 
>   if config.get('xcode_settings', {}).get('IPHONEOS_DEPLOYMENT_TARGET'):

Done.

https://codereview.chromium.org/25355002/diff/45001/pylib/gyp/xcode_emulation...
pylib/gyp/xcode_emulation.py:1206: def AddIOSDeviceConfigurations(targets):
On 2013/10/04 19:35:07, Nico wrote:
> Also add a _ in front of the name

Done.