Issue 2535373002: QUIC - bugfix for forced head of line blocking experiment. Guarded by ENABLED --FLAGS_quic_bugfix_f…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2535373002: QUIC - bugfix for forced head of line blocking experiment. Guarded by ENABLED --FLAGS_quic_bugfix_f… (Closed)

Created:
4 years ago by Victor Vasiliev

Modified:
4 years ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

QUIC - bugfix for forced head of line blocking experiment. Guarded by ENABLED --FLAGS_quic_bugfix_fhol_writev_fin_only_v2. Fix bugs in FHOL: o handle fin-only writev correctly. o limit additional buffering to one HTTP/2 Data frame (~16KB). o make headers stream flow control a large fixed size, rather than using autotuning. This is a redo of internal change 134345701, the only difference being the headers stream flow control window size. Merge internal change: 136086759 This is a re-application of https://codereview.chromium.org/2414193002, after it got reverted by accident during the merge. R=rch@chromium.org BUG=

Patch Set 1 #

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+197 lines, -48 lines)			Patch
M	net/quic/core/quic_headers_stream.h	View	1 chunk	+7 lines, -2 lines	0 comments	Download
M	net/quic/core/quic_headers_stream.cc	View	2 chunks	+103 lines, -40 lines	0 comments	Download
M	net/quic/core/quic_headers_stream_test.cc	View	2 chunks	+69 lines, -0 lines	0 comments	Download
M	net/quic/core/quic_spdy_session.cc	View	1 chunk	+18 lines, -6 lines	0 comments	Download

Depends on Patchset:

Issue 2537233002 Patch 20001

Dependent Patchsets:

Issue 2536033004 Patch 1

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages