Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Issue 2414193002: QUIC - bugfix for forced head of line blocking experiment. Guarded by ENABLED --FLAGS_quic_bugfix_f… (Closed)

Created:
4 years, 2 months ago by Buck
Modified:
4 years, 2 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

QUIC - bugfix for forced head of line blocking experiment. Guarded by ENABLED --FLAGS_quic_bugfix_fhol_writev_fin_only_v2. Fix bugs in FHOL: o handle fin-only writev correctly. o limit additional buffering to one HTTP/2 Data frame (~16KB). o make headers stream flow control a large fixed size, rather than using autotuning. This is a redo of internal change 134345701, the only difference being the headers stream flow control window size. Merge internal change: 136086759 BUG= Committed: https://crrev.com/17ddab309f9274fccf9ea108d097ba7cd0ef88f8 Cr-Commit-Position: refs/heads/master@{#425219}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -57 lines) Patch
M net/quic/core/quic_flags_list.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/core/quic_headers_stream.h View 1 chunk +7 lines, -2 lines 0 comments Download
M net/quic/core/quic_headers_stream.cc View 2 chunks +103 lines, -40 lines 0 comments Download
M net/quic/core/quic_headers_stream_test.cc View 2 chunks +69 lines, -0 lines 0 comments Download
M net/quic/core/quic_spdy_session.cc View 1 chunk +18 lines, -6 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 2 chunks +13 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Buck
4 years, 2 months ago (2016-10-13 23:20:20 UTC) #4
Ryan Hamilton
lgtm
4 years, 2 months ago (2016-10-13 23:38:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2414193002/1
4 years, 2 months ago (2016-10-14 00:37:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 00:45:03 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 00:48:45 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/17ddab309f9274fccf9ea108d097ba7cd0ef88f8
Cr-Commit-Position: refs/heads/master@{#425219}

Powered by Google App Engine
This is Rietveld 408576698