Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2535313004: [Chromecast] Clarify lifetime of CastGinRunner. (Closed)

Created:
4 years ago by derekjchow1
Modified:
4 years ago
Reviewers:
slan, alokp
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Clarify lifetime of CastGinRunner. CastGinRunner is now owned by the gin::PerContextData associated with a content::RenderFrame. Do not rely on RenderFrameObserver notifications to manager it's lifetime. Instead, this class will be deleted when gin::PerContextData is destroyed. BUG=internal b/32916396 R=slan@chromium.org,alokp@chromium.org Committed: https://crrev.com/693c2b9347ccbd85043b9dff0cbc18824a14e7b5 Cr-Commit-Position: refs/heads/master@{#435640}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address nits #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -61 lines) Patch
M chromecast/renderer/cast_content_renderer_client.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chromecast/renderer/cast_gin_runner.h View 2 chunks +14 lines, -18 lines 0 comments Download
M chromecast/renderer/cast_gin_runner.cc View 1 2 chunks +24 lines, -41 lines 2 comments Download

Messages

Total messages: 20 (11 generated)
derekjchow1
The following documentation might help clarify ownership questions you might have. https://cs.chromium.org/chromium/src/base/supports_user_data.h?l=34
4 years ago (2016-11-30 19:06:57 UTC) #3
slan
https://codereview.chromium.org/2535313004/diff/1/chromecast/renderer/cast_gin_runner.cc File chromecast/renderer/cast_gin_runner.cc (right): https://codereview.chromium.org/2535313004/diff/1/chromecast/renderer/cast_gin_runner.cc#newcode18 chromecast/renderer/cast_gin_runner.cc:18: const void* kCastGinRunnerKey = static_cast<const void*>(kCastGinRunnerKey); kCastContextData? (with declaration ...
4 years ago (2016-11-30 19:26:09 UTC) #6
derekjchow1
https://codereview.chromium.org/2535313004/diff/1/chromecast/renderer/cast_gin_runner.cc File chromecast/renderer/cast_gin_runner.cc (right): https://codereview.chromium.org/2535313004/diff/1/chromecast/renderer/cast_gin_runner.cc#newcode18 chromecast/renderer/cast_gin_runner.cc:18: const void* kCastGinRunnerKey = static_cast<const void*>(kCastGinRunnerKey); On 2016/11/30 19:26:09, ...
4 years ago (2016-11-30 22:32:34 UTC) #11
slan
lgtm https://codereview.chromium.org/2535313004/diff/20001/chromecast/renderer/cast_gin_runner.cc File chromecast/renderer/cast_gin_runner.cc (right): https://codereview.chromium.org/2535313004/diff/20001/chromecast/renderer/cast_gin_runner.cc#newcode19 chromecast/renderer/cast_gin_runner.cc:19: const void* kCastGinRunnerKey = static_cast<const void*>(&kCastContextData); nit: Could ...
4 years ago (2016-12-01 01:33:22 UTC) #12
slan
https://codereview.chromium.org/2535313004/diff/20001/chromecast/renderer/cast_gin_runner.cc File chromecast/renderer/cast_gin_runner.cc (right): https://codereview.chromium.org/2535313004/diff/20001/chromecast/renderer/cast_gin_runner.cc#newcode19 chromecast/renderer/cast_gin_runner.cc:19: const void* kCastGinRunnerKey = static_cast<const void*>(&kCastContextData); On 2016/12/01 01:33:22, ...
4 years ago (2016-12-01 01:37:51 UTC) #13
alokp
lgtm
4 years ago (2016-12-01 05:15:31 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2535313004/20001
4 years ago (2016-12-01 17:34:34 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-01 17:38:57 UTC) #18
commit-bot: I haz the power
4 years ago (2016-12-01 17:41:00 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/693c2b9347ccbd85043b9dff0cbc18824a14e7b5
Cr-Commit-Position: refs/heads/master@{#435640}

Powered by Google App Engine
This is Rietveld 408576698