chromecast/renderer/cast_content_renderer_client.cc - Issue 2535313004: [Chromecast] Clarify lifetime of CastGinRunner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/renderer/cast_content_renderer_client.cc

Issue 2535313004: [Chromecast] Clarify lifetime of CastGinRunner. (Closed)

Patch Set: Address nits Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromecast/renderer/cast_content_renderer_client.cc

diff --git a/chromecast/renderer/cast_content_renderer_client.cc b/chromecast/renderer/cast_content_renderer_client.cc

index b625bd956f9097761878b098986afc35920f062a..718403ab16566cfa12aa4b014cb19aae7ba56c99 100644

--- a/chromecast/renderer/cast_content_renderer_client.cc

+++ b/chromecast/renderer/cast_content_renderer_client.cc

@@ -148,8 +148,7 @@ void CastContentRendererClient::RunScriptsAtDocumentStart(

v8::Local<v8::Context> context =

render_frame->GetWebFrame()->mainWorldScriptContext();

- // CastGinRunner manages its own lifetime.

- CastGinRunner* runner = new CastGinRunner(render_frame);

+ CastGinRunner* runner = CastGinRunner::Get(render_frame);

gin::Runner::Scope scoper(runner);

// Initialize AMD API for Mojo.