Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(824)

Issue 2535223002: [ast] Remove unused BailoutIds for ClassLiteral. (Closed)

Created:
4 years ago by Michael Starzinger
Modified:
4 years ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ast] Remove unused BailoutIds for ClassLiteral. This removes reservation of unused {BailoutId} numbers for all class literals. These language constructs are by now solely funneled through bytecode and specific ids for deoptimization are no longer needed. R=rmcilroy@chromium.org BUG=v8:5657 Committed: https://crrev.com/d045f41c5c271974938aa9e4f922d8e762f0dd22 Cr-Commit-Position: refs/heads/master@{#41358}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -14 lines) Patch
M src/ast/ast.h View 2 chunks +0 lines, -13 lines 0 comments Download
M src/ast/ast-numbering.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
Michael Starzinger
4 years ago (2016-11-29 12:15:17 UTC) #3
rmcilroy
Thanks for cleaning this up! LGTM.
4 years ago (2016-11-29 12:46:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2535223002/1
4 years ago (2016-11-29 12:49:22 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 12:51:06 UTC) #10
commit-bot: I haz the power
4 years ago (2016-11-29 12:51:41 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d045f41c5c271974938aa9e4f922d8e762f0dd22
Cr-Commit-Position: refs/heads/master@{#41358}

Powered by Google App Engine
This is Rietveld 408576698