Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 2533283002: [fullcodegen] Remove with-statement support. (Closed)

Created:
4 years ago by Michael Starzinger
Modified:
4 years ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[fullcodegen] Remove with-statement support. This removes support for dynamic scoping via with-statement constructs from the {FullCodeGenerator}. Consequently optimized code containing such constructs must use the {BytecodeGraphBuilder} and can no longer use the {AstGraphBuilder} for graph building. R=rmcilroy@chromium.org BUG=v8:5657 Committed: https://crrev.com/957f3f10e56011edd15d6dd8c473a0d753885eb4 Cr-Commit-Position: refs/heads/master@{#41365}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -70 lines) Patch
M src/ast/ast.h View 1 chunk +0 lines, -14 lines 0 comments Download
M src/ast/ast-numbering.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/ast-graph-builder.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/ast-graph-builder.cc View 2 chunks +2 lines, -14 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +0 lines, -13 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +2 lines, -27 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (7 generated)
Michael Starzinger
4 years ago (2016-11-29 12:58:06 UTC) #3
rmcilroy
Awesome, LGTM, thanks.
4 years ago (2016-11-29 15:21:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2533283002/1
4 years ago (2016-11-29 15:26:50 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 15:28:53 UTC) #10
commit-bot: I haz the power
4 years ago (2016-11-29 15:29:13 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/957f3f10e56011edd15d6dd8c473a0d753885eb4
Cr-Commit-Position: refs/heads/master@{#41365}

Powered by Google App Engine
This is Rietveld 408576698