Revert of Handle empty string in GetSavePasswordDialogTitleTextAndLinkRange gracefully

Revert of Handle empty string in GetSavePasswordDialogTitleTextAndLinkRange gracefully (patchset #1 id:1 of https://codereview.chromium.org/2534113002/ )

Reason for revert:
Compile failure.
BUG=669394
Original issue's description:
> Handle empty string in GetSavePasswordDialogTitleTextAndLinkRange gracefully
> 
> GetSavePasswordDialogTitleTextAndLinkRange currently assumes that localised
> strings for particular IDs contain placeholders, and attempts to access the
> vector of offsets corresponding to such placeholders. However, in some
> situations (http://crbug.com/658902#c18) the localised string may be empty.
> This led to an out-of-bounds access and crash on Android.
> 
> This CL is the smallest change to handle such situation gracefully -- it checks
> the length of the vector with offsets and gives up accessing it if it is empty.
> This avoids the crash but results in displaying a UI with empty strings.
> Ideally, the UI would also be supressed on these occasions, but that is left
> for follow-up CLs. The current situation is already an improvement (password
> manager is still not very useful, but at least the browser has a chance to
> continue).
> 
> The CL also removes the temporary logging put in for the crash investigation.
> 
> BUG=658902
> 
> Review-Url: https://codereview.chromium.org/2526283002
> Cr-Commit-Position: refs/heads/master@{#434482}
> (cherry picked from commit 49ebcf7d64e71c7d3ac71bca66f65d61180bfb8c)
> 
> Committed: https://chromium.googlesource.com/chromium/src/+/910f52d5209148d0ad1afa8cbfb9360d65fcb00e

TBR=
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=658902

[vabr (Chromium), 2016-11-29 08:11:11]

The CQ bit was checked by vabr@chromium.org

[vabr (Chromium), 2016-11-29 08:11:12]

Created Revert of Handle empty string in
GetSavePasswordDialogTitleTextAndLinkRange gracefully

[commit-bot: I haz the power, 2016-11-29 08:11:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 08:15:16]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480407071704040, "parent_rev":
"f7b7dffb33b30c1bb9d027f298d5d2ee1df4f818", "commit_rev":
"7356f07e6938b4c6d1950250247160682ba6e3bc"}

[commit-bot: I haz the power, 2016-11-29 08:15:44]

Description was changed from

==========
Revert of Handle empty string in GetSavePasswordDialogTitleTextAndLinkRange
gracefully (patchset #1 id:1 of https://codereview.chromium.org/2534113002/ )

Reason for revert:
Compile failure.
BUG=669394

Original issue's description:
> Handle empty string in GetSavePasswordDialogTitleTextAndLinkRange gracefully
> 
> GetSavePasswordDialogTitleTextAndLinkRange currently assumes that localised
> strings for particular IDs contain placeholders, and attempts to access the
> vector of offsets corresponding to such placeholders. However, in some
> situations (http://crbug.com/658902#c18) the localised string may be empty.
> This led to an out-of-bounds access and crash on Android.
> 
> This CL is the smallest change to handle such situation gracefully -- it
checks
> the length of the vector with offsets and gives up accessing it if it is
empty.
> This avoids the crash but results in displaying a UI with empty strings.
> Ideally, the UI would also be supressed on these occasions, but that is left
> for follow-up CLs. The current situation is already an improvement (password
> manager is still not very useful, but at least the browser has a chance to
> continue).
> 
> The CL also removes the temporary logging put in for the crash investigation.
> 
> BUG=658902
> 
> Review-Url: https://codereview.chromium.org/2526283002
> Cr-Commit-Position: refs/heads/master@{#434482}
> (cherry picked from commit 49ebcf7d64e71c7d3ac71bca66f65d61180bfb8c)
> 
> Committed:
https://chromium.googlesource.com/chromium/src/+/910f52d5209148d0ad1afa8cbfb9...

TBR=
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=658902
==========

to

==========
Revert of Handle empty string in GetSavePasswordDialogTitleTextAndLinkRange
gracefully (patchset #1 id:1 of https://codereview.chromium.org/2534113002/ )

Reason for revert:
Compile failure.
BUG=669394

Original issue's description:
> Handle empty string in GetSavePasswordDialogTitleTextAndLinkRange gracefully
> 
> GetSavePasswordDialogTitleTextAndLinkRange currently assumes that localised
> strings for particular IDs contain placeholders, and attempts to access the
> vector of offsets corresponding to such placeholders. However, in some
> situations (http://crbug.com/658902#c18) the localised string may be empty.
> This led to an out-of-bounds access and crash on Android.
> 
> This CL is the smallest change to handle such situation gracefully -- it
checks
> the length of the vector with offsets and gives up accessing it if it is
empty.
> This avoids the crash but results in displaying a UI with empty strings.
> Ideally, the UI would also be supressed on these occasions, but that is left
> for follow-up CLs. The current situation is already an improvement (password
> manager is still not very useful, but at least the browser has a chance to
> continue).
> 
> The CL also removes the temporary logging put in for the crash investigation.
> 
> BUG=658902
> 
> Review-Url: https://codereview.chromium.org/2526283002
> Cr-Commit-Position: refs/heads/master@{#434482}
> (cherry picked from commit 49ebcf7d64e71c7d3ac71bca66f65d61180bfb8c)
> 
> Committed:
https://chromium.googlesource.com/chromium/src/+/910f52d5209148d0ad1afa8cbfb9...

TBR=
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=658902
==========

[commit-bot: I haz the power, 2016-11-29 08:15:45]

Committed patchset #1 (id:1)