Revert of Handle empty string in GetSavePasswordDialogTitleTextAndLinkRange gracefully

chrome/browser/ui/passwords/manage_passwords_view_utils.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/passwords/manage_passwords_view_utils.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 
@@ skipping 98 matching lines @@
     replacements.push_back(
         url_formatter::FormatUrlForSecurityDisplay(form_origin_url));
   }
 
   if (is_smartlock_branding_enabled) {
     // "Google Smart Lock" should be a hyperlink.
     base::string16 title_link =
         l10n_util::GetStringUTF16(IDS_PASSWORD_MANAGER_SMART_LOCK);
     replacements.insert(replacements.begin(), title_link);
     *title = l10n_util::GetStringFUTF16(title_id, replacements, &offsets);
-    if (!offsets.empty()) {
-      // |offsets| can be empty when the localised string associated with
-      // |title_id| could not be found. While this situation is an error, it
-      // needs to be handled gracefully, see http://crbug.com/658902#c18.
-      *title_link_range =
-          gfx::Range(offsets[0], offsets[0] + title_link.length());
-    }
+    *title_link_range =
+        gfx::Range(offsets[0], offsets[0] + title_link.length());
   } else {
     replacements.insert(
         replacements.begin(),
         l10n_util::GetStringUTF16(IDS_PASSWORD_MANAGER_TITLE_BRAND));
     *title = l10n_util::GetStringFUTF16(title_id, replacements, &offsets);
   }
 }
 
 void GetManagePasswordsDialogTitleText(const GURL& user_visible_url,
                                        const GURL& password_origin_url,
@@ skipping 51 matching lines @@
              : form.username_value;
 }
 
 bool IsSyncingAutosignSetting(Profile* profile) {
   const browser_sync::ProfileSyncService* sync_service =
       ProfileSyncServiceFactory::GetForProfile(profile);
   return (sync_service && sync_service->IsFirstSetupComplete() &&
           sync_service->IsSyncActive() &&
           sync_service->GetActiveDataTypes().Has(syncer::PRIORITY_PREFERENCES));
 }