content/test/gpu/gpu_tests/pixel_expectations.py - Issue 2535173002: Prevent implicit framebuffer clear from clobbering alpha in emulated RGB

Side by Side Diff: content/test/gpu/gpu_tests/pixel_expectations.py

Issue 2535173002: Prevent implicit framebuffer clear from clobbering alpha in emulated RGB (Closed)

Patch Set: fix Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « content/test/data/gpu/pixel_webgl_noalpha_implicit_clear.html ('k') | content/test/gpu/gpu_tests/pixel_test_pages.py » ('j') | content/test/gpu/gpu_tests/pixel_test_pages.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 from gpu_tests.gpu_test_expectations import GpuTestExpectations	5 from gpu_tests.gpu_test_expectations import GpuTestExpectations

6	6

7 # See the GpuTestExpectations class for documentation.	7 # See the GpuTestExpectations class for documentation.

8	8

9 class PixelExpectations(GpuTestExpectations):	9 class PixelExpectations(GpuTestExpectations):

10 def SetExpectations(self):	10 def SetExpectations(self):

(...skipping 22 matching lines...) Expand all Loading...
33 self.Fail('Pixel_OffscreenCanvasUnaccelerated2DGPUCompositingWorker',	33 self.Fail('Pixel_OffscreenCanvasUnaccelerated2DGPUCompositingWorker',

34 ['mac', ('nvidia', 0xfe9)], bug=652931)	34 ['mac', ('nvidia', 0xfe9)], bug=652931)

35	35

36 # TODO(kbr): flakily timing out on this configuration.	36 # TODO(kbr): flakily timing out on this configuration.

37 self.Flaky('*', ['linux', 'intel', 'debug'], bug=648369)	37 self.Flaky('*', ['linux', 'intel', 'debug'], bug=648369)

38	38

39 # Flaky for unknown reasons only on macOS. Not planning to investigate	39 # Flaky for unknown reasons only on macOS. Not planning to investigate

40 # further.	40 # further.

41 self.Flaky('Pixel_ScissorTestWithPreserveDrawingBuffer', ['mac'],	41 self.Flaky('Pixel_ScissorTestWithPreserveDrawingBuffer', ['mac'],

42 bug=660461)	42 bug=660461)

	43

	44 # TODO(kainino): remove this once golden images are generated

	45 self.Fail('Pixel_WebGLGreenTriangle_NonChromiumImage_NoAA_NoAlpha', bug=6662 59)
	Ken Russell (switch to Gerrit) 2016/12/01 07:20:43 The name in this suppression is wrong -- not clear The name in this suppression is wrong -- not clear to me why the mac_chromium_rel_ng tryjob passed. It should have failed. Ken Russell (switch to Gerrit) 2016/12/01 08:00:54 Facepalm When I ported the pixel_tests to the n Show quoted text On 2016/12/01 07:20:43, Ken Russell wrote: > The name in this suppression is wrong -- not clear to me why the > mac_chromium_rel_ng tryjob passed. It should have failed. Facepalm When I ported the pixel_tests to the new harness a couple of months ago I accidentally dropped the Mac-specific pages. I'm so sorry. Fixing in https://codereview.chromium.org/2547463002 . Please do run your new test on all platforms though. Kai Ninomiya 2016/12/01 23:30:19 Done. Show quoted text On 2016/12/01 08:00:54, Ken Russell wrote: > On 2016/12/01 07:20:43, Ken Russell wrote: > > The name in this suppression is wrong -- not clear to me why the > > mac_chromium_rel_ng tryjob passed. It should have failed. > > Facepalm > > When I ported the pixel_tests to the new harness a couple of months ago I > accidentally dropped the Mac-specific pages. I'm so sorry. Fixing in > https://codereview.chromium.org/2547463002 . Please do run your new test on all > platforms though. Done.
OLD	NEW