Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 2547463002: Start running the Mac-specific pixel test pages again. (Closed)

Created:
4 years ago by Ken Russell (switch to Gerrit)
Modified:
4 years ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org, Kai Ninomiya, erikchen, ccameron
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Start running the Mac-specific pixel test pages again. These were accidentally dropped during the port to the new harness a while back. BUG=352807 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=zmo@chromium.org Committed: https://crrev.com/d28b98c7245514faadb3717413b8797d4451c3be Cr-Commit-Position: refs/heads/master@{#435591}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M content/test/gpu/gpu_tests/pixel_integration_test.py View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Ken Russell (switch to Gerrit)
Mo: PTAL Others: FYI. I'm really sorry about missing this in https://codereview.chromium.org/2363343002 .
4 years ago (2016-12-01 07:59:40 UTC) #3
Ken Russell (switch to Gerrit)
Fortunately, these tests didn't get broken in the past two months when they weren't run. ...
4 years ago (2016-12-01 09:44:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2547463002/1
4 years ago (2016-12-01 09:44:32 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 10:52:34 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d28b98c7245514faadb3717413b8797d4451c3be Cr-Commit-Position: refs/heads/master@{#435591}
4 years ago (2016-12-01 10:54:30 UTC) #12
Zhenyao Mo
4 years ago (2016-12-01 19:01:28 UTC) #13
Message was sent while issue was closed.
On 2016/12/01 10:54:30, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/d28b98c7245514faadb3717413b8797d4451c3be
> Cr-Commit-Position: refs/heads/master@{#435591}

lgtm after the fact

Powered by Google App Engine
This is Rietveld 408576698