cros: More robust approach for setting login/lock webview background color.

cros: More robust approach for setting login/lock webview background color.

BUG=669638
Committed: https://crrev.com/665ecfc70ddc424fd4e0409b3a9600517c266603
Cr-Commit-Position: refs/heads/master@{#435107}

[jdufault, 2016-11-28 23:26:17]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 23:27:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 02:13:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 02:13:50]

Dry run: This issue passed the CQ dry run.

[jdufault, 2016-11-29 17:04:03]

Description was changed from

==========
More robust approach for settings webview background color.

BUG=
==========

to

==========
More robust approach for settings webview background color.

BUG=452599
==========

[jdufault, 2016-11-29 17:04:49]

jdufault@chromium.org changed reviewers:
+ achuith@chromium.org

[jdufault, 2016-11-29 17:05:01]

achuith@, PTAL. Thanks!

[jdufault, 2016-11-29 17:06:33]

Description was changed from

==========
More robust approach for settings webview background color.

BUG=452599
==========

to

==========
More robust approach for setting login/lock webview background color.

BUG=452599
==========

[jdufault, 2016-11-29 17:06:50]

Description was changed from

==========
More robust approach for setting login/lock webview background color.

BUG=452599
==========

to

==========
cros: More robust approach for setting login/lock webview background color.

BUG=452599
==========

[jdufault, 2016-11-29 17:07:30]

On 2016/11/29 17:05:01, jdufault wrote:
> achuith@, PTAL. Thanks!

Some additional context: This prevents some visual glitches w.r.t. the webview
transparency when the webview is shared between lock sessions.

[achuithb, 2016-11-29 20:37:06]

I'm not clear on how this is related to 452599, but if this is the closest
tracking bug to this effort, that's fine.

lgtm.

https://codereview.chromium.org/2535093002/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/ui/web_contents_set_background_color.cc
(right):

https://codereview.chromium.org/2535093002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/ui/web_contents_set_background_color.cc:19: if
(FromWebContents(web_contents))
Does Create get called multiple times?

https://codereview.chromium.org/2535093002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/ui/web_contents_set_background_color.cc:22:
web_contents->SetUserData(
Please add a comment explaining that SupportsUserData::Data takes ownership and
will destroy this when webcontents is destroyed.

https://codereview.chromium.org/2535093002/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/ui/web_contents_set_background_color.h
(right):

https://codereview.chromium.org/2535093002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/ui/web_contents_set_background_color.h:11: using
SkColor = unsigned int;
Add a comment - this is intended to be the same as the ARGB 32 bit SkColor from
skia's SkColor.h, right?

https://codereview.chromium.org/2535093002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/ui/web_contents_set_background_color.h:36: SkColor
color_;
Is there some default that makes sense?

[jdufault, 2016-11-29 20:46:18]

Description was changed from

==========
cros: More robust approach for setting login/lock webview background color.

BUG=452599
==========

to

==========
cros: More robust approach for setting login/lock webview background color.

BUG=669638
==========

[jdufault, 2016-11-29 20:54:30]

I've created a separate bug tracking this work and updated the BUG= field.

https://codereview.chromium.org/2535093002/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/ui/web_contents_set_background_color.cc
(right):

https://codereview.chromium.org/2535093002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/ui/web_contents_set_background_color.cc:19: if
(FromWebContents(web_contents))
On 2016/11/29 20:37:06, achuithb wrote:
> Does Create get called multiple times?

It can, yea. This also seems to be a common pattern.

https://codereview.chromium.org/2535093002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/ui/web_contents_set_background_color.cc:22:
web_contents->SetUserData(
On 2016/11/29 20:37:06, achuithb wrote:
> Please add a comment explaining that SupportsUserData::Data takes ownership
and
> will destroy this when webcontents is destroyed.

Done.

https://codereview.chromium.org/2535093002/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/ui/web_contents_set_background_color.h
(right):

https://codereview.chromium.org/2535093002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/ui/web_contents_set_background_color.h:11: using
SkColor = unsigned int;
On 2016/11/29 20:37:06, achuithb wrote:
> Add a comment - this is intended to be the same as the ARGB 32 bit SkColor
from
> skia's SkColor.h, right?

Done.

https://codereview.chromium.org/2535093002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/ui/web_contents_set_background_color.h:36: SkColor
color_;
On 2016/11/29 20:37:06, achuithb wrote:
> Is there some default that makes sense?

I don't think so, especially since we are not pulling in SkColor so SK_* color
values are not available. This is also initialized in the ctor.

[jdufault, 2016-11-29 20:54:41]

The CQ bit was checked by jdufault@chromium.org

[jdufault, 2016-11-29 20:54:42]

The patchset sent to the CQ was uploaded after l-g-t-m from achuith@chromium.org
Link to the patchset: https://codereview.chromium.org/2535093002/#ps20001
(title: "Address comments")

[commit-bot: I haz the power, 2016-11-29 20:55:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 23:39:46]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480452881690330,
"parent_rev": "0a7e0acf515d6c29deec26845bbbd29ae58be5b7", "commit_rev":
"0d01ab8dc29507a2b82e8d7bf9e35c7ace90d961"}

[commit-bot: I haz the power, 2016-11-29 23:40:23]

Description was changed from

==========
cros: More robust approach for setting login/lock webview background color.

BUG=669638
==========

to

==========
cros: More robust approach for setting login/lock webview background color.

BUG=669638
==========

[commit-bot: I haz the power, 2016-11-29 23:40:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-29 23:42:36]

Description was changed from

==========
cros: More robust approach for setting login/lock webview background color.

BUG=669638
==========

to

==========
cros: More robust approach for setting login/lock webview background color.

BUG=669638

Committed: https://crrev.com/665ecfc70ddc424fd4e0409b3a9600517c266603
Cr-Commit-Position: refs/heads/master@{#435107}
==========

[commit-bot: I haz the power, 2016-11-29 23:42:37]

Patchset 2 (id:??) landed as
https://crrev.com/665ecfc70ddc424fd4e0409b3a9600517c266603
Cr-Commit-Position: refs/heads/master@{#435107}