Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2535093002: cros: More robust approach for setting login/lock webview background color. (Closed)

Created:
4 years ago by jdufault
Modified:
4 years ago
Reviewers:
achuithb
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: More robust approach for setting login/lock webview background color. BUG=669638 Committed: https://crrev.com/665ecfc70ddc424fd4e0409b3a9600517c266603 Cr-Commit-Position: refs/heads/master@{#435107}

Patch Set 1 #

Total comments: 8

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -7 lines) Patch
M chrome/browser/chromeos/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/ui/web_contents_set_background_color.h View 1 1 chunk +44 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/ui/web_contents_set_background_color.cc View 1 1 chunk +55 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/ui/webui_login_view.cc View 2 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
jdufault
achuith@, PTAL. Thanks!
4 years ago (2016-11-29 17:05:01 UTC) #7
jdufault
On 2016/11/29 17:05:01, jdufault wrote: > achuith@, PTAL. Thanks! Some additional context: This prevents some ...
4 years ago (2016-11-29 17:07:30 UTC) #10
achuithb
I'm not clear on how this is related to 452599, but if this is the ...
4 years ago (2016-11-29 20:37:06 UTC) #11
jdufault
I've created a separate bug tracking this work and updated the BUG= field. https://codereview.chromium.org/2535093002/diff/1/chrome/browser/chromeos/login/ui/web_contents_set_background_color.cc File ...
4 years ago (2016-11-29 20:54:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2535093002/20001
4 years ago (2016-11-29 20:55:34 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-29 23:40:23 UTC) #19
commit-bot: I haz the power
4 years ago (2016-11-29 23:42:37 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/665ecfc70ddc424fd4e0409b3a9600517c266603
Cr-Commit-Position: refs/heads/master@{#435107}

Powered by Google App Engine
This is Rietveld 408576698