Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6345)

Unified Diff: chrome/browser/chromeos/login/ui/webui_login_view.cc

Issue 2535093002: cros: More robust approach for setting login/lock webview background color. (Closed)
Patch Set: Address comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/login/ui/web_contents_set_background_color.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/ui/webui_login_view.cc
diff --git a/chrome/browser/chromeos/login/ui/webui_login_view.cc b/chrome/browser/chromeos/login/ui/webui_login_view.cc
index 2df5d2cb58a8fd1a8507adb0945d565cf02a9cf4..a83d5c8f085fa1988a18c71af55731a1cad655cd 100644
--- a/chrome/browser/chromeos/login/ui/webui_login_view.cc
+++ b/chrome/browser/chromeos/login/ui/webui_login_view.cc
@@ -21,6 +21,7 @@
#include "chrome/browser/chromeos/accessibility/accessibility_util.h"
#include "chrome/browser/chromeos/login/ui/login_display_host_impl.h"
#include "chrome/browser/chromeos/login/ui/proxy_settings_dialog.h"
+#include "chrome/browser/chromeos/login/ui/web_contents_set_background_color.h"
#include "chrome/browser/chromeos/login/ui/webui_login_display.h"
#include "chrome/browser/chromeos/profiles/profile_helper.h"
#include "chrome/browser/chromeos/settings/cros_settings.h"
@@ -351,13 +352,8 @@ void WebUILoginView::LoadURL(const GURL & url) {
webui_login_->LoadInitialURL(url);
webui_login_->RequestFocus();
- // TODO(nkostylev): Use WebContentsObserver::RenderViewCreated to track
- // when RenderView is created.
- GetWebContents()
- ->GetRenderViewHost()
- ->GetWidget()
- ->GetView()
- ->SetBackgroundColor(SK_ColorTRANSPARENT);
+ WebContentsSetBackgroundColor::CreateForWebContentsWithColor(
+ GetWebContents(), SK_ColorTRANSPARENT);
// There is no Shell instance while running in mash.
if (chrome::IsRunningInMash())
« no previous file with comments | « chrome/browser/chromeos/login/ui/web_contents_set_background_color.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698