chrome/browser/android/offline_pages/offline_page_utils_unittest.cc - Issue 2535023002: [Offline pages] Fixing OfflinePageUtis::EqualsIgnoringFragment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/offline_page_utils_unittest.cc

Issue 2535023002: [Offline pages] Fixing OfflinePageUtis::EqualsIgnoringFragment (Closed)

Patch Set: Addressing feedback Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/offline_pages/offline_page_utils.cc ('k') | chrome/browser/previews/previews_infobar_tab_helper_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/offline_page_utils_unittest.cc

diff --git a/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc b/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc

index d666a319737caf56c8a8d09ac3ca9defad69920c..6ed1c4c042ff2431f887280f35b049b35685b886 100644

--- a/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc

+++ b/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc

@@ -262,4 +262,17 @@ TEST_F(OfflinePageUtilsTest, CheckExistenceOfRequestsWithURL) {

EXPECT_TRUE(latest_saved_time.is_null());

}

+TEST_F(OfflinePageUtilsTest, EqualsIgnoringFragment) {

+ EXPECT_TRUE(OfflinePageUtils::EqualsIgnoringFragment(

+ GURL("http://example.com/"), GURL("http://example.com/")));

+ EXPECT_TRUE(OfflinePageUtils::EqualsIgnoringFragment(

+ GURL("http://example.com/"), GURL("http://example.com/#test")));

+ EXPECT_TRUE(OfflinePageUtils::EqualsIgnoringFragment(

+ GURL("http://example.com/#test"), GURL("http://example.com/")));

+ EXPECT_TRUE(OfflinePageUtils::EqualsIgnoringFragment(

+ GURL("http://example.com/#test"), GURL("http://example.com/#test2")));

+ EXPECT_FALSE(OfflinePageUtils::EqualsIgnoringFragment(

+ GURL("http://example.com/"), GURL("http://test.com/#test")));

} // namespace offline_pages