Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 2534963002: Make Omnibox stay visible during long page loads. (Closed)

Created:
4 years ago by cjgrant
Modified:
4 years ago
Reviewers:
mthiesse, bshe
CC:
chromium-reviews, feature-vr-reviews_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make Omnibox stay visible during long page loads. The omnibox visibility timer should not be active during a page load; it should be started only after loading finishes. BUG=641508 TEST=Viewed a page that takes 10s to load; omnibox stays visible. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/a38ed6430b5688221a944d9994cc2231405a7360 Cr-Commit-Position: refs/heads/master@{#435007}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/resources/vr_shell/vr_shell_ui.js View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
cjgrant
4 years ago (2016-11-28 16:55:51 UTC) #3
bshe
On 2016/11/28 16:55:51, cjgrant wrote: lgtm
4 years ago (2016-11-28 18:01:08 UTC) #4
mthiesse
lgtm
4 years ago (2016-11-28 18:40:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2534963002/1
4 years ago (2016-11-28 18:53:28 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/170857) win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, ...
4 years ago (2016-11-28 19:34:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2534963002/1
4 years ago (2016-11-29 14:41:46 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 16:18:50 UTC) #13
commit-bot: I haz the power
4 years ago (2016-11-29 16:20:30 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a38ed6430b5688221a944d9994cc2231405a7360
Cr-Commit-Position: refs/heads/master@{#435007}

Powered by Google App Engine
This is Rietveld 408576698