Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2640)

Unified Diff: chrome/browser/resources/vr_shell/vr_shell_ui.js

Issue 2534963002: Make Omnibox stay visible during long page loads. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/vr_shell/vr_shell_ui.js
diff --git a/chrome/browser/resources/vr_shell/vr_shell_ui.js b/chrome/browser/resources/vr_shell/vr_shell_ui.js
index ee7a3cf0caedd2f563a87d663396797e2d7a8692..1aaddf6187293654c930513ee37cc221eb89ab80 100644
--- a/chrome/browser/resources/vr_shell/vr_shell_ui.js
+++ b/chrome/browser/resources/vr_shell/vr_shell_ui.js
@@ -309,7 +309,7 @@ var vrShellUi = (function() {
clearInterval(this.visibilityTimer);
this.visibilityTimer = null;
}
- if (this.enabled && this.visibilityTimeout > 0) {
+ if (this.enabled && this.visibilityTimeout > 0 && !this.loading) {
this.visibilityTimer = setTimeout(
this.onVisibilityTimer.bind(this), this.visibilityTimeout);
}
@@ -339,11 +339,11 @@ var vrShellUi = (function() {
let state = 'idle';
this.visibleAfterTransition = true;
- if (this.visibilityTimeout > 0 && !this.visibilityTimer) {
+ if (this.loading) {
+ state = 'loading';
+ } else if (this.visibilityTimeout > 0 && !this.visibilityTimer) {
state = 'hide';
this.visibleAfterTransition = false;
- } else if (this.loading) {
- state = 'loading';
}
document.querySelector('#omni').className = state;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698