editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/HintCode.java - Issue 253493010: Change the error for importing a deferred library with a top-level 'loadLibrary' to being a hint. A…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/HintCode.java

Issue 253493010: Change the error for importing a deferred library with a top-level 'loadLibrary' to being a hint. A… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Code Review Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java ('k') | editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/hint/BestPracticesVerifier.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/HintCode.java

diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/HintCode.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/HintCode.java

index c9466badab30d3c76f7dbd5f140711e21c675810..0f9bc1c6c0db1c356430c22e18368a9437ea4fc8 100644

--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/HintCode.java

+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/HintCode.java

@@ -93,6 +93,12 @@ public enum HintCode implements ErrorCode {

"When compiled to JS, this test might return false when the left hand side is a double"),

/**

+ * Deferred libraries shouldn't define a top level function 'loadLibrary'.

+ */

+ IMPORT_DEFERRED_LIBRARY_WITH_LOAD_FUNCTION(

+ "The library '%s' defines a top-level function named 'loadLibrary' which is hidden by deferring this library"),

+ /**

* This hint is generated anywhere where the {@link StaticTypeWarningCode#INVALID_ASSIGNMENT}

* would have been generated, if we used propagated information for the warnings.