Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java

Issue 253493010: Change the error for importing a deferred library with a top-level 'loadLibrary' to being a hint. A… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code Review Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java
diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java
index 650a1276284cb82afce781ee3e16e341998e7fa2..417d46860c10eeabf50e7a3671eded882ce10a8f 100644
--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java
+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java
@@ -13,7 +13,6 @@
*/
package com.google.dart.engine.error;
-
/**
* The enumeration {@code CompileTimeErrorCode} defines the error codes used for compile time
* errors. The convention for this class is for the name of the error code to indicate the problem
@@ -573,14 +572,6 @@ public enum CompileTimeErrorCode implements ErrorCode {
IMPLICIT_THIS_REFERENCE_IN_INITIALIZER("Only static members can be accessed in initializers"),
/**
- * Speculative.
- * <p>
- * TODO (jwren) Revisit to remove after we know for sure that this won't be in the Spec.
- */
- IMPORT_DEFERRED_LIBRARY_WITH_LOAD_FUNCTION(
- "The library '%s' defines a top-level function named 'loadLibrary' and therefore cannot be deferred"),
-
- /**
* SDK implementation libraries can be imported only by other SDK libraries.
*
* @param uri the uri pointing to a library

Powered by Google App Engine
This is Rietveld 408576698