Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 253493004: Instrumented libraries: use 'rm -rf' instead of 'shutil.rmtree'. (Closed)

Created:
6 years, 8 months ago by earthdok
Modified:
6 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Instrumented libraries: use 'rm -rf' instead of 'shutil.rmtree'. The latter may fail because permissions. BUG=313751 TBR=glider@chromium.org NOTRY=true TEST=msan Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266200

Patch Set 1 #

Patch Set 2 : restore empty line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/instrumented_libraries/download_build_install.py View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
earthdok
6 years, 8 months ago (2014-04-25 16:08:50 UTC) #1
earthdok
6 years, 8 months ago (2014-04-25 16:09:21 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 manually as r266200 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698