Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: third_party/instrumented_libraries/download_build_install.py

Issue 253493004: Instrumented libraries: use 'rm -rf' instead of 'shutil.rmtree'. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: restore empty line Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/instrumented_libraries/download_build_install.py
diff --git a/third_party/instrumented_libraries/download_build_install.py b/third_party/instrumented_libraries/download_build_install.py
index 40cb1353cbc6034814d185b717c30da4b6b2c203..33f81e059079708fa6430f34ab7a2735c03e940e 100755
--- a/third_party/instrumented_libraries/download_build_install.py
+++ b/third_party/instrumented_libraries/download_build_install.py
@@ -296,7 +296,7 @@ def download_build_install(parsed_arguments):
# A failed build might have left a dirty source tree behind.
if os.path.exists(library_directory):
- shutil.rmtree(library_directory)
+ shell_call('rm -rf %s' % library_directory, parsed_arguments.verbose)
os.makedirs(library_directory)
with ScopedChangeDirectory(library_directory) as cd_library:
@@ -330,7 +330,7 @@ def download_build_install(parsed_arguments):
# Remove downloaded package and generated temporary build files.
# Failed builds intentionally skip this step, in order to aid in tracking down
# build failures.
- shutil.rmtree(library_directory)
+ shell_call('rm -rf %s' % library_directory, parsed_arguments.verbose)
def main():
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698