Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(988)

Unified Diff: chrome/browser/chromeos/arc/arc_support_host.h

Issue 2534883002: Extract ArcTermsOfServiceNegotiator implementation. (Closed)
Patch Set: Address comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/arc/arc_support_host.h
diff --git a/chrome/browser/chromeos/arc/arc_support_host.h b/chrome/browser/chromeos/arc/arc_support_host.h
index 1712611a7d89d03f5cbfc1649ac794adc441ae76..9a33c41a17166439747d8b4cd5e7df56e72940a2 100644
--- a/chrome/browser/chromeos/arc/arc_support_host.h
+++ b/chrome/browser/chromeos/arc/arc_support_host.h
@@ -8,6 +8,7 @@
#include <memory>
#include <string>
+#include "base/callback.h"
#include "base/macros.h"
#include "base/observer_list.h"
#include "chrome/browser/chromeos/arc/extensions/arc_support_message_host.h"
@@ -51,8 +52,6 @@ class ArcSupportHost : public arc::ArcSupportMessageHost::Observer,
virtual void OnWindowClosed() {}
// Called when the user press AGREE button on ToS page.
- // TODO(hidehiko): Currently, due to implementation reason,
- // this is also called when RETRY on error page is clicked. Fix this.
virtual void OnTermsAgreed(bool is_metrics_enabled,
bool is_backup_and_restore_enabled,
bool is_location_service_enabled) {}
@@ -70,6 +69,8 @@ class ArcSupportHost : public arc::ArcSupportMessageHost::Observer,
static const char kHostAppId[];
static const char kStorageId[];
+ using RequestOpenAppCallback = base::Callback<void(Profile* profile)>;
+
explicit ArcSupportHost(Profile* profile);
~ArcSupportHost() override;
@@ -124,6 +125,9 @@ class ArcSupportHost : public arc::ArcSupportMessageHost::Observer,
// TODO(hidehiko): Remove this exposure.
UIPage ui_page() const { return ui_page_; }
+ void SetRequestOpenAppCallbackForTesting(
+ const RequestOpenAppCallback& callback);
+
private:
struct PreferenceCheckboxData {
PreferenceCheckboxData() : PreferenceCheckboxData(false, false) {}
@@ -155,6 +159,7 @@ class ArcSupportHost : public arc::ArcSupportMessageHost::Observer,
void DisconnectMessageHost();
Profile* const profile_;
+ RequestOpenAppCallback request_open_app_callback_;
base::ObserverList<Observer> observer_list_;

Powered by Google App Engine
This is Rietveld 408576698