Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Unified Diff: chrome/browser/chromeos/arc/optin/arc_terms_of_service_negotiator_unittest.cc

Issue 2534883002: Extract ArcTermsOfServiceNegotiator implementation. (Closed)
Patch Set: Address comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/arc/optin/arc_terms_of_service_negotiator_unittest.cc
diff --git a/chrome/browser/chromeos/arc/optin/arc_terms_of_service_negotiator_unittest.cc b/chrome/browser/chromeos/arc/optin/arc_terms_of_service_negotiator_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..4feb8716b451d31f1af29430dbde1be540033c17
--- /dev/null
+++ b/chrome/browser/chromeos/arc/optin/arc_terms_of_service_negotiator_unittest.cc
@@ -0,0 +1,193 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <memory>
+#include <ostream>
+
+#include "base/bind.h"
+#include "base/macros.h"
+#include "base/memory/ptr_util.h"
+#include "base/run_loop.h"
+#include "chrome/browser/chromeos/arc/arc_support_host.h"
+#include "chrome/browser/chromeos/arc/extensions/fake_arc_support.h"
+#include "chrome/browser/chromeos/arc/optin/arc_terms_of_service_negotiator.h"
+#include "chrome/browser/chromeos/login/users/fake_chrome_user_manager.h"
+#include "chrome/browser/chromeos/login/users/scoped_user_manager_enabler.h"
+#include "chrome/common/pref_names.h"
+#include "chrome/test/base/testing_browser_process.h"
+#include "chrome/test/base/testing_profile.h"
+#include "components/prefs/pref_service.h"
+#include "content/public/test/test_browser_thread_bundle.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace arc {
+
+class ArcTermsOfServiceNegotiatorTest : public testing::Test {
+ public:
+ ArcTermsOfServiceNegotiatorTest() = default;
+ ~ArcTermsOfServiceNegotiatorTest() override = default;
+
+ void SetUp() override {
+ user_manager_enabler_ =
+ base::MakeUnique<chromeos::ScopedUserManagerEnabler>(
+ new chromeos::FakeChromeUserManager());
+
+ profile_ = base::MakeUnique<TestingProfile>();
+ profile_->GetPrefs()->SetBoolean(prefs::kArcBackupRestoreEnabled, false);
+ profile_->GetPrefs()->SetBoolean(prefs::kArcLocationServiceEnabled, false);
+
+ support_host_ = base::MakeUnique<ArcSupportHost>(profile_.get());
+ fake_arc_support_ = base::MakeUnique<FakeArcSupport>(support_host_.get());
+ negotiator_ = base::MakeUnique<ArcTermsOfServiceNegotiator>(
+ profile_->GetPrefs(), support_host());
+ }
+
+ void TearDown() override {
+ negotiator_.reset();
+ fake_arc_support_.reset();
+ support_host_.reset();
+ profile_.reset();
+ user_manager_enabler_.reset();
+ }
+
+ Profile* profile() { return profile_.get(); }
+ ArcSupportHost* support_host() { return support_host_.get(); }
+ FakeArcSupport* fake_arc_support() { return fake_arc_support_.get(); }
+ ArcTermsOfServiceNegotiator* negotiator() { return negotiator_.get(); }
+
+ private:
+ // Fake as if the current testing thread is UI thread.
+ content::TestBrowserThreadBundle bundle_;
+
+ std::unique_ptr<TestingProfile> profile_;
+ std::unique_ptr<chromeos::ScopedUserManagerEnabler> user_manager_enabler_;
+ std::unique_ptr<ArcSupportHost> support_host_;
+ std::unique_ptr<FakeArcSupport> fake_arc_support_;
+ std::unique_ptr<ArcTermsOfServiceNegotiator> negotiator_;
+
+ DISALLOW_COPY_AND_ASSIGN(ArcTermsOfServiceNegotiatorTest);
+};
+
+namespace {
+
+enum class Status {
+ PENDING,
+ ACCEPTED,
hidehiko 2016/12/02 08:47:22 Note: one more forgotten AGREED. Fixed.
+ CANCELLED,
+};
+
+// For better logging.
+std::ostream& operator<<(std::ostream& os, Status status) {
+ switch (status) {
+ case Status::PENDING:
+ return os << "PENDING";
+ case Status::ACCEPTED:
+ return os << "ACCEPTED";
+ case Status::CANCELLED:
+ return os << "CANCELLED";
+ }
+
+ NOTREACHED();
+ return os;
+}
+
+ArcTermsOfServiceNegotiator::NegotiationCallback UpdateStatusCallback(
+ Status* status) {
+ return base::Bind(
+ [](Status* status, bool accepted) {
+ *status = accepted ? Status::ACCEPTED : Status::CANCELLED;
+ },
+ status);
+}
+
+} // namespace
+
+TEST_F(ArcTermsOfServiceNegotiatorTest, Accept) {
+ // Show Terms of service page.
+ Status status = Status::PENDING;
+ negotiator()->StartNegotiation(UpdateStatusCallback(&status));
+
+ // TERMS page should be shown.
+ EXPECT_EQ(status, Status::PENDING);
+ EXPECT_EQ(fake_arc_support()->ui_page(), ArcSupportHost::UIPage::TERMS);
+
+ // Check the preference related checkbox.
+ fake_arc_support()->set_metrics_mode(true);
+ fake_arc_support()->set_backup_and_restore_mode(true);
+ fake_arc_support()->set_location_service_mode(true);
+
+ // Make sure preference values are not yet updated.
+ EXPECT_FALSE(
+ profile()->GetPrefs()->GetBoolean(prefs::kArcBackupRestoreEnabled));
+ EXPECT_FALSE(
+ profile()->GetPrefs()->GetBoolean(prefs::kArcLocationServiceEnabled));
+
+ // Click the "AGREE" button so that the callback should be invoked
+ // with |agreed| = true.
+ fake_arc_support()->ClickAgreeButton();
+ EXPECT_EQ(status, Status::ACCEPTED);
+
+ // Make sure preference values are now updated.
+ EXPECT_TRUE(
+ profile()->GetPrefs()->GetBoolean(prefs::kArcBackupRestoreEnabled));
+ EXPECT_TRUE(
+ profile()->GetPrefs()->GetBoolean(prefs::kArcLocationServiceEnabled));
+}
+
+TEST_F(ArcTermsOfServiceNegotiatorTest, Cancel) {
+ // Show Terms of service page.
+ Status status = Status::PENDING;
+ negotiator()->StartNegotiation(UpdateStatusCallback(&status));
+
+ // TERMS page should be shown.
+ EXPECT_EQ(status, Status::PENDING);
+ EXPECT_EQ(fake_arc_support()->ui_page(), ArcSupportHost::UIPage::TERMS);
+
+ // Check the preference related checkbox.
+ fake_arc_support()->set_metrics_mode(true);
+ fake_arc_support()->set_backup_and_restore_mode(true);
+ fake_arc_support()->set_location_service_mode(true);
+
+ // Make sure preference values are not yet updated.
+ EXPECT_FALSE(
+ profile()->GetPrefs()->GetBoolean(prefs::kArcBackupRestoreEnabled));
+ EXPECT_FALSE(
+ profile()->GetPrefs()->GetBoolean(prefs::kArcLocationServiceEnabled));
+
+ // Clicking "CANCEL" button closes the window.
+ fake_arc_support()->Close();
+ EXPECT_EQ(status, Status::CANCELLED);
+
+ // Make sure preference checkbox values are discarded.
+ EXPECT_FALSE(
+ profile()->GetPrefs()->GetBoolean(prefs::kArcBackupRestoreEnabled));
+ EXPECT_FALSE(
+ profile()->GetPrefs()->GetBoolean(prefs::kArcLocationServiceEnabled));
+}
+
+TEST_F(ArcTermsOfServiceNegotiatorTest, Retry) {
+ // Show Terms of service page.
+ Status status = Status::PENDING;
+ negotiator()->StartNegotiation(UpdateStatusCallback(&status));
+
+ // TERMS page should be shown.
+ EXPECT_EQ(status, Status::PENDING);
+ EXPECT_EQ(fake_arc_support()->ui_page(), ArcSupportHost::UIPage::TERMS);
+
+ // Switch to error page.
+ support_host()->ShowError(ArcSupportHost::Error::SIGN_IN_NETWORK_ERROR,
+ false);
+
+ // The callback should not be called yet.
+ EXPECT_EQ(status, Status::PENDING);
+ EXPECT_EQ(fake_arc_support()->ui_page(), ArcSupportHost::UIPage::ERROR);
+
+ // Click RETRY button on the page, then Terms of service page should be
+ // re-shown.
+ fake_arc_support()->ClickRetryButton();
+ EXPECT_EQ(status, Status::PENDING);
+ EXPECT_EQ(fake_arc_support()->ui_page(), ArcSupportHost::UIPage::TERMS);
+}
+
+} // namespace arc
« no previous file with comments | « chrome/browser/chromeos/arc/optin/arc_terms_of_service_negotiator.cc ('k') | chrome/browser/policy/policy_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698