MacViews: Harmony for TabDialogs' dialogs (starting with Collected Cookies)

MacViews: Harmony for TabDialogs' dialogs (starting with Collected Cookies)

Collected cookies when invoked from the site info bubble (padlock ->
Cookies -> click the "X in use" link) is already hooked up to
--secondary-ui-md. However, it can also be shown via the content
settings bubble when a cookie is blocked.

We also need TabDialogs' Signin confirmation dialog switched to Harmony,
so set up a way to show Harmony dialogs from the TabDialogs interface.

Opt collected cookies into DialogBrowserTest to make it easy to invoke
for testing.

BUG=654151, 677012, 610428
Review-Url: https://codereview.chromium.org/2534743002
Cr-Commit-Position: refs/heads/master@{#443130}
Committed: https://chromium.googlesource.com/chromium/src/+/3888fbf6c8994f26f65ba506341a475b0c2f4e1f

[tapted, 2016-11-28 04:59:45]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 04:59:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 05:49:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 05:49:38]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tapted, 2016-11-28 07:57:42]

Description was changed from

==========
Opt collected cookies into DialogBrowserTest

BUG=649908
==========

to

==========
Opt collected cookies into DialogBrowserTest

BUG=654151
==========

[tapted, 2016-11-29 08:25:22]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 08:25:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 09:15:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 09:15:41]

Dry run: This issue passed the CQ dry run.

[tapted, 2016-12-07 03:23:54]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 03:24:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 04:43:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 04:43:14]

Dry run: This issue passed the CQ dry run.

[tapted, 2017-01-10 03:21:06]

Description was changed from

==========
Opt collected cookies into DialogBrowserTest

BUG=654151
==========

to

==========
Opt collected cookies into DialogBrowserTest

BUG=654151, 677012
==========

[tapted, 2017-01-11 02:04:57]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 02:05:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 04:20:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 04:20:39]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tapted, 2017-01-11 16:10:52]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 16:11:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tapted, 2017-01-11 16:25:11]

Description was changed from

==========
Opt collected cookies into DialogBrowserTest

BUG=654151, 677012
==========

to

==========
MacViews: Harmony for TabDialogs' dialogs (starting with Collected Cookies)

Collected cookies when invoked from the site info bubble (padlock ->
Cookies -> click the "X in use" link) is already hooked up to
--secondary-ui-md. However, it can also be shown via the content
settings bubble when a cookie is blocked.

We also need TabDialogs' Signin confirmation dialog switched to Harmony,
so set up a way to show Harmony dialogs from the TabDialogs interface.

Opt collected cookies into DialogBrowserTest to make it easy to invoke
for testing.

BUG=654151, 677012
==========

[tapted, 2017-01-11 16:26:03]

Description was changed from

==========
MacViews: Harmony for TabDialogs' dialogs (starting with Collected Cookies)

Collected cookies when invoked from the site info bubble (padlock ->
Cookies -> click the "X in use" link) is already hooked up to
--secondary-ui-md. However, it can also be shown via the content
settings bubble when a cookie is blocked.

We also need TabDialogs' Signin confirmation dialog switched to Harmony,
so set up a way to show Harmony dialogs from the TabDialogs interface.

Opt collected cookies into DialogBrowserTest to make it easy to invoke
for testing.

BUG=654151, 677012
==========

to

==========
MacViews: Harmony for TabDialogs' dialogs (starting with Collected Cookies)

Collected cookies when invoked from the site info bubble (padlock ->
Cookies -> click the "X in use" link) is already hooked up to
--secondary-ui-md. However, it can also be shown via the content
settings bubble when a cookie is blocked.

We also need TabDialogs' Signin confirmation dialog switched to Harmony,
so set up a way to show Harmony dialogs from the TabDialogs interface.

Opt collected cookies into DialogBrowserTest to make it easy to invoke
for testing.

BUG=654151, 677012, 610428
==========

[tapted, 2017-01-11 16:26:03]

tapted@chromium.org changed reviewers:
+ rsesek@chromium.org

[commit-bot: I haz the power, 2017-01-11 17:03:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 17:03:55]

Dry run: This issue passed the CQ dry run.

[tapted, 2017-01-11 17:05:37]

Hiya robert, please take a look. There was an alternative in patchset 2, but
this approach allows the views-specific deps to be be contained in their own
file. - Thanks!

[Robert Sesek, 2017-01-11 19:47:34]

LGTM

[tapted, 2017-01-11 20:17:33]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 20:18:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tapted, 2017-01-11 20:20:50]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 20:21:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 20:39:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 20:39:15]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[tapted, 2017-01-11 20:56:45]

tapted@chromium.org changed reviewers:
+ sky@chromium.org

[tapted, 2017-01-11 20:56:46]

+sky for chrome/browser/collected_cookies_browsertest.cc OWNERS

(also while picking OWNERS I thought it was weird that this test file was in
chrome/browser rather than chrome/browser/ui, so I moved it).

[sky, 2017-01-11 21:56:30]

LGTM

[tapted, 2017-01-12 01:56:42]

The CQ bit was checked by tapted@chromium.org

[tapted, 2017-01-12 01:56:42]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org
Link to the patchset: https://codereview.chromium.org/2534743002/#ps160001
(title: "Move browsertest to chrome/browser/ui + similarity=20%")

[commit-bot: I haz the power, 2017-01-12 01:57:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 02:55:25]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1484186202117380,
"parent_rev": "590f8e6768702a8172c67b3cda7745107b6b1e0d", "commit_rev":
"3888fbf6c8994f26f65ba506341a475b0c2f4e1f"}

[commit-bot: I haz the power, 2017-01-12 02:55:57]

Description was changed from

==========
MacViews: Harmony for TabDialogs' dialogs (starting with Collected Cookies)

Collected cookies when invoked from the site info bubble (padlock ->
Cookies -> click the "X in use" link) is already hooked up to
--secondary-ui-md. However, it can also be shown via the content
settings bubble when a cookie is blocked.

We also need TabDialogs' Signin confirmation dialog switched to Harmony,
so set up a way to show Harmony dialogs from the TabDialogs interface.

Opt collected cookies into DialogBrowserTest to make it easy to invoke
for testing.

BUG=654151, 677012, 610428
==========

to

==========
MacViews: Harmony for TabDialogs' dialogs (starting with Collected Cookies)

Collected cookies when invoked from the site info bubble (padlock ->
Cookies -> click the "X in use" link) is already hooked up to
--secondary-ui-md. However, it can also be shown via the content
settings bubble when a cookie is blocked.

We also need TabDialogs' Signin confirmation dialog switched to Harmony,
so set up a way to show Harmony dialogs from the TabDialogs interface.

Opt collected cookies into DialogBrowserTest to make it easy to invoke
for testing.

BUG=654151, 677012, 610428

Review-Url: https://codereview.chromium.org/2534743002
Cr-Commit-Position: refs/heads/master@{#443130}
Committed:
https://chromium.googlesource.com/chromium/src/+/3888fbf6c8994f26f65ba506341a...
==========

[commit-bot: I haz the power, 2017-01-12 02:55:58]

Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/3888fbf6c8994f26f65ba506341a...