[Sensors] Layouts test to check frequency hint

[Sensors] Layouts test to check frequency hint

This patch introduces layout tests checking frequency hint for sensors having both 'onchange' and 'continuous' reporting.

BUG=606766
Committed: https://crrev.com/947057f3628e20376c783e30f9fcc03d86a8ee49
Cr-Commit-Position: refs/heads/master@{#435214}

[Mikhail, 2016-11-27 11:55:58]

The CQ bit was checked by mikhail.pozdnyakov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-27 11:56:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mikhail, 2016-11-27 11:57:38]

Description was changed from

==========
[Sensors] Layouts test to check frequency hint

This patch introduces layout tests checking frequency hint for sensors having
both 'onchange' and 'continuous' reporting.

BUG=
==========

to

==========
[Sensors] Layouts test to check frequency hint

This patch introduces layout tests checking frequency hint for sensors having
both 'onchange' and 'continuous' reporting.

BUG=606766
==========

[commit-bot: I haz the power, 2016-11-27 13:24:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-27 13:24:07]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Mikhail, 2016-11-28 10:18:02]

The CQ bit was checked by mikhail.pozdnyakov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 10:18:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mikhail, 2016-11-28 10:19:13]

mikhail.pozdnyakov@intel.com changed reviewers:
+ alexander.shalamov@intel.com, haraken@chromium.org, reillyg@chromium.org

[Mikhail, 2016-11-28 10:43:42]

PTAL

[haraken, 2016-11-28 10:54:52]

LGTM on my side

[commit-bot: I haz the power, 2016-11-28 11:19:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 11:19:30]

Dry run: This issue passed the CQ dry run.

[shalamov, 2016-11-28 12:24:19]

lgtm

[Reilly Grant (use Gerrit), 2016-11-28 19:22:54]

lgtm with nits and a question I think I know the answer to.

https://codereview.chromium.org/2534703002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/sensor/accelerometer.html (right):

https://codereview.chromium.org/2534703002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/sensor/accelerometer.html:26: }
nit: Unnecessary braces.

https://codereview.chromium.org/2534703002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/sensor/ambient-light-sensor.html (right):

https://codereview.chromium.org/2534703002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/sensor/ambient-light-sensor.html:22: }
nit: Unnecessary braces.

https://codereview.chromium.org/2534703002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/sensor/gyroscope.html (right):

https://codereview.chromium.org/2534703002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/sensor/gyroscope.html:26: }
nit: Unnecessary braces.

https://codereview.chromium.org/2534703002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/sensor/magnetometer.html (right):

https://codereview.chromium.org/2534703002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/sensor/magnetometer.html:26: }
nit: Unnecessary braces.

https://codereview.chromium.org/2534703002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js
(right):

https://codereview.chromium.org/2534703002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js:171:
.then((mockSensor) => {
nit: unnecessary parens

https://codereview.chromium.org/2534703002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js:272:
sensor2.onerror = reject;
What about onchange for sensor2?

https://codereview.chromium.org/2534703002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js:290:
.then((mockSensor) => {
nit: unnecessary parens

[Mikhail, 2016-11-30 09:31:05]

The CQ bit was checked by mikhail.pozdnyakov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 09:31:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mikhail, 2016-11-30 10:31:30]

Thanks for your comments!

https://codereview.chromium.org/2534703002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/sensor/accelerometer.html (right):

https://codereview.chromium.org/2534703002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/sensor/accelerometer.html:26: }
On 2016/11/28 19:22:53, Reilly Grant wrote:
> nit: Unnecessary braces.

Done.

https://codereview.chromium.org/2534703002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/sensor/ambient-light-sensor.html (right):

https://codereview.chromium.org/2534703002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/sensor/ambient-light-sensor.html:22: }
On 2016/11/28 19:22:53, Reilly Grant wrote:
> nit: Unnecessary braces.

Done.

https://codereview.chromium.org/2534703002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/sensor/gyroscope.html (right):

https://codereview.chromium.org/2534703002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/sensor/gyroscope.html:26: }
On 2016/11/28 19:22:53, Reilly Grant wrote:
> nit: Unnecessary braces.

Done.

https://codereview.chromium.org/2534703002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/sensor/magnetometer.html (right):

https://codereview.chromium.org/2534703002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/sensor/magnetometer.html:26: }
On 2016/11/28 19:22:53, Reilly Grant wrote:
> nit: Unnecessary braces.

Done.

https://codereview.chromium.org/2534703002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js
(right):

https://codereview.chromium.org/2534703002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js:171:
.then((mockSensor) => {
On 2016/11/28 19:22:53, Reilly Grant wrote:
> nit: unnecessary parens

Done.

https://codereview.chromium.org/2534703002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js:272:
sensor2.onerror = reject;
On 2016/11/28 19:22:53, Reilly Grant wrote:
> What about onchange for sensor2?
This test checks that all sensor instances share the same instance of reading, I
thought that it'd be enough to check it on first update. If required I can add
the same check also at 2nd sensor change in a following patch, but it should not
really influence the result as codepath is the same.

https://codereview.chromium.org/2534703002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js:290:
.then((mockSensor) => {
On 2016/11/28 19:22:53, Reilly Grant wrote:
> nit: unnecessary parens

Done.

[commit-bot: I haz the power, 2016-11-30 11:07:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 11:07:28]

Dry run: This issue passed the CQ dry run.

[Mikhail, 2016-11-30 11:09:47]

The CQ bit was checked by mikhail.pozdnyakov@intel.com

[Mikhail, 2016-11-30 11:09:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, reillyg@chromium.org, alexander.shalamov@intel.com
Link to the patchset: https://codereview.chromium.org/2534703002/#ps40001
(title: "Comments from Reilly")

[commit-bot: I haz the power, 2016-11-30 11:10:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 11:13:38]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480504187904970,
"parent_rev": "a637dff95da8bf1033fe34208d8a61dd8ae409ce", "commit_rev":
"516a08c534840abe787bed33cdca731ce5ce2cda"}

[commit-bot: I haz the power, 2016-11-30 11:14:02]

Description was changed from

==========
[Sensors] Layouts test to check frequency hint

This patch introduces layout tests checking frequency hint for sensors having
both 'onchange' and 'continuous' reporting.

BUG=606766
==========

to

==========
[Sensors] Layouts test to check frequency hint

This patch introduces layout tests checking frequency hint for sensors having
both 'onchange' and 'continuous' reporting.

BUG=606766
==========

[commit-bot: I haz the power, 2016-11-30 11:14:03]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-30 11:15:58]

Description was changed from

==========
[Sensors] Layouts test to check frequency hint

This patch introduces layout tests checking frequency hint for sensors having
both 'onchange' and 'continuous' reporting.

BUG=606766
==========

to

==========
[Sensors] Layouts test to check frequency hint

This patch introduces layout tests checking frequency hint for sensors having
both 'onchange' and 'continuous' reporting.

BUG=606766

Committed: https://crrev.com/947057f3628e20376c783e30f9fcc03d86a8ee49
Cr-Commit-Position: refs/heads/master@{#435214}
==========

[commit-bot: I haz the power, 2016-11-30 11:15:59]

Patchset 3 (id:??) landed as
https://crrev.com/947057f3628e20376c783e30f9fcc03d86a8ee49
Cr-Commit-Position: refs/heads/master@{#435214}