third_party/WebKit/LayoutTests/sensor/magnetometer.html - Issue 2534703002: [Sensors] Layouts test to check frequency hint

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/sensor/magnetometer.html

Issue 2534703002: [Sensors] Layouts test to check frequency hint (Closed)

Patch Set: fixed MagnetometerReading::isReadingUpdated Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/sensor/gyroscope.html ('K') | « third_party/WebKit/LayoutTests/sensor/gyroscope.html ('k') | third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js » ('j') | third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../resources/testharness.js"></script>	2 <script src="../resources/testharness.js"></script>

3 <script src="../resources/testharnessreport.js"></script>	3 <script src="../resources/testharnessreport.js"></script>

4 <script src="../resources/mojo-helpers.js"></script>	4 <script src="../resources/mojo-helpers.js"></script>

5 <script src="resources/sensor-helpers.js"></script>	5 <script src="resources/sensor-helpers.js"></script>

6 <script src="resources/generic-sensor-tests.js"></script>	6 <script src="resources/generic-sensor-tests.js"></script>

7 <script>	7 <script>

8	8

9 'use strict';	9 'use strict';

10	10

11 if (!window.testRunner)	11 if (!window.testRunner)

12 debug('This test cannot be run without the TestRunner');	12 debug('This test cannot be run without the TestRunner');

13	13

14 const kDefaultReadingValueX = -19.2;	14 const kDefaultReadingValueX = -19.2;

15 const kDefaultReadingValueY = 12.1;	15 const kDefaultReadingValueY = 12.1;

16 const kDefaultReadingValueZ = -44.3;	16 const kDefaultReadingValueZ = -44.3;

	17 var readsCount = 0;

17	18

18 function update_sensor_reading(buffer) {	19 function update_sensor_reading(buffer, expects_modified_reading) {

19 buffer[1] = window.performance.now();	20 buffer[1] = window.performance.now();

20 buffer[2] = kDefaultReadingValueX;	21 buffer[2] = kDefaultReadingValueX;

21 buffer[3] = kDefaultReadingValueY;	22 buffer[3] = kDefaultReadingValueY;

22 buffer[4] = kDefaultReadingValueZ;	23 buffer[4] = kDefaultReadingValueZ;

	24 if (expects_modified_reading) {

	25 buffer[2] += readsCount;

	26 }
	Reilly Grant (use Gerrit) 2016/11/28 19:22:53 nit: Unnecessary braces. nit: Unnecessary braces. Mikhail 2016/11/30 10:31:30 Done. Show quoted text On 2016/11/28 19:22:53, Reilly Grant wrote: > nit: Unnecessary braces. Done.
	27 readsCount++;

23 }	28 }

24	29

25 function verify_sensor_reading(reading) {	30 function verify_sensor_reading(reading) {

26 return reading.x == kDefaultReadingValueX &&	31 return reading.x == kDefaultReadingValueX &&

27 reading.y == kDefaultReadingValueY &&	32 reading.y == kDefaultReadingValueY &&

28 reading.z == kDefaultReadingValueZ;	33 reading.z == kDefaultReadingValueZ;

29 }	34 }

30	35

31 runGenericSensorTests(Magnetometer, update_sensor_reading, verify_sensor_reading );	36 runGenericSensorTests(Magnetometer, update_sensor_reading, verify_sensor_reading );

32 </script>	37 </script>

OLD	NEW