Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2534693002: Reduce usage of webkit prefixes in extension examples (Closed)

Created:
4 years ago by Eric Willigers
Modified:
3 years, 9 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce usage of webkit prefixes in extension examples CSS Animations and Transitions do not require a -webkit prefix. BUG=668650 Review-Url: https://codereview.chromium.org/2534693002 Cr-Commit-Position: refs/heads/master@{#454018} Committed: https://chromium.googlesource.com/chromium/src/+/e4acaaab00a612c34db400319d5b9b9a0b6ff73f

Patch Set 1 #

Patch Set 2 : dedup #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -56 lines) Patch
M chrome/common/extensions/docs/examples/api/browsingData/basic/popup.css View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/document_scan/scan.css View 1 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/downloads/download_manager/popup.css View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/fontSettings/css/chrome_shared.css View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/fontSettings/css/overlay.css View 1 2 3 chunks +13 lines, -13 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/fontSettings/css/widgets.css View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/fontSettings/js/cr/ui/overlay.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/examples/api/fontSettings/options.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/examples/extensions/irc/servlet/styles.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/examples/extensions/news/css/feed.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/examples/extensions/news/javascript/options.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/news_a11y/feed.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/examples/extensions/news_i18n/feed.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/examples/extensions/plugin_settings/css/plugin_list.css View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/plugin_settings/options/css/list.css View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/proxy_configuration/popup.css View 1 2 8 chunks +11 lines, -11 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/angular_framework.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/articles/api_other.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/sencha_framework.html View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
Eric Willigers
4 years ago (2016-11-26 11:41:20 UTC) #2
Eric Willigers
I generated this CL, and the others for this bug, using a script. sed -i ...
3 years, 10 months ago (2017-02-14 01:26:25 UTC) #9
Eric Willigers
chrome/ and ui/ can soon have a presubmit trigger to reject webkit-transform, webkit-animation, webkit-transition.
3 years, 10 months ago (2017-02-23 04:09:37 UTC) #11
Ken Rockot(use gerrit already)
lgtm
3 years, 9 months ago (2017-03-01 18:43:45 UTC) #12
Ken Rockot(use gerrit already)
I just noticed this in my review queue btw. Sorry if you were waiting long ...
3 years, 9 months ago (2017-03-01 18:44:26 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2534693002/40001
3 years, 9 months ago (2017-03-01 20:10:00 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 20:27:05 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e4acaaab00a612c34db400319d5b...

Powered by Google App Engine
This is Rietveld 408576698