mus: Move MusGpuMemoryBufferManager into common.

mus: Move MusGpuMemoryBufferManager into common.

MusGpuMemoryBufferManager needs to be used by both the window server (to
service gpu memory requests from clients), and the gpu process (for the
display compositor). So move it into a service_common that various server
components can use.

BUG=none

Committed: https://crrev.com/d9ea7ed90d1de14db8eca3ed1df66c6851f13648
Cr-Commit-Position: refs/heads/master@{#434681}

[sadrul, 2016-11-25 21:32:57]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 21:33:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 21:36:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 21:36:41]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sadrul, 2016-11-25 21:45:09]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 21:45:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-11-25 21:46:25]

sadrul@chromium.org changed reviewers:
+ fsamuel@chromium.org

[sadrul, 2016-11-25 21:47:19]

Note: GpuServiceProxy doesn't use the MusGMBManager instances yet, but it's
going to soon (CL: https://codereview.chromium.org/2503113002/)

[Fady Samuel, 2016-11-25 21:52:44]

lgtm

[sadrul, 2016-11-26 00:47:55]

sadrul@chromium.org changed reviewers:
+ sky@chromium.org

[sadrul, 2016-11-26 00:47:55]

+sky@ for owner review of the rest.

[commit-bot: I haz the power, 2016-11-26 01:16:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-26 01:16:10]

Dry run: This issue passed the CQ dry run.

[Fady Samuel, 2016-11-26 12:10:04]

BTW, MojoGpuMemoryBufferManager and MusGpuMemoryBufferManager are pretty bad
names. I can't tell from the name alone which is which and what they do :P

[sky, 2016-11-26 16:42:19]

https://codereview.chromium.org/2534663002/diff/20001/services/ui/common/BUIL...
File services/ui/common/BUILD.gn (right):

https://codereview.chromium.org/2534663002/diff/20001/services/ui/common/BUIL...
services/ui/common/BUILD.gn:39: source_set("service_common") {
service_common is quite redundant given this is the common directory in the
service directory. How about 'gpu'? At least add a description as what this is
for.

[sadrul, 2016-11-27 00:54:43]

On 2016/11/26 12:10:04, Fady Samuel wrote:
> BTW, MojoGpuMemoryBufferManager and MusGpuMemoryBufferManager are pretty bad
> names. I can't tell from the name alone which is which and what they do :P

How about: MojoGpuMemoryBufferManager => ClientGpuMemoryBufferManager, and
MusGpuMemoryBufferManager =>
HostGpuMemoryBufferManager/ServerGpuMemoryBufferManager/GpuMemoryBufferManager?

[Fady Samuel, 2016-11-27 01:04:36]

On 2016/11/27 00:54:43, sadrul wrote:
> On 2016/11/26 12:10:04, Fady Samuel wrote:
> > BTW, MojoGpuMemoryBufferManager and MusGpuMemoryBufferManager are pretty bad
> > names. I can't tell from the name alone which is which and what they do :P
> 
> How about: MojoGpuMemoryBufferManager => ClientGpuMemoryBufferManager, and
> MusGpuMemoryBufferManager =>
>
HostGpuMemoryBufferManager/ServerGpuMemoryBufferManager/GpuMemoryBufferManager?

+1 to ClientGpuMemoryBufferManager.

I don't like HostGpuMemoryBufferManager for the other one because that implies
just the window server in my mind. "ServerGpuMemoryBufferManager" is more
generic which better captures the fact that it's used by both mus-ws AND
mus-gpu. Just GpuMemoryBufferManager is too generic.

[sadrul, 2016-11-27 01:13:44]

https://codereview.chromium.org/2534663002/diff/20001/services/ui/common/BUIL...
File services/ui/common/BUILD.gn (right):

https://codereview.chromium.org/2534663002/diff/20001/services/ui/common/BUIL...
services/ui/common/BUILD.gn:39: source_set("service_common") {
On 2016/11/26 16:42:19, sky wrote:
> service_common is quite redundant given this is the common directory in the
> service directory. How about 'gpu'? At least add a description as what this is
> for.

The 'mus_common' target above is used by both the window-server and mus-clients.
That's why I thought it'd be good to have a name that makes it obvious that this
is not for clients. Maybe server_common, or service_gpu?

[sadrul, 2016-11-27 04:14:58]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-27 04:15:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-11-27 04:16:25]

https://codereview.chromium.org/2534663002/diff/20001/services/ui/common/BUIL...
File services/ui/common/BUILD.gn (right):

https://codereview.chromium.org/2534663002/diff/20001/services/ui/common/BUIL...
services/ui/common/BUILD.gn:39: source_set("service_common") {
On 2016/11/27 01:13:44, sadrul wrote:
> On 2016/11/26 16:42:19, sky wrote:
> > service_common is quite redundant given this is the common directory in the
> > service directory. How about 'gpu'? At least add a description as what this
is
> > for.
> 
> The 'mus_common' target above is used by both the window-server and
mus-clients.
> That's why I thought it'd be good to have a name that makes it obvious that
this
> is not for clients. Maybe server_common, or service_gpu?

Renamed to 'server_gpu', and added comment here to mention where this is used.

[commit-bot: I haz the power, 2016-11-27 06:56:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-27 06:56:17]

Dry run: This issue passed the CQ dry run.

[sky, 2016-11-28 16:11:44]

LGTM

[sadrul, 2016-11-28 16:50:03]

The CQ bit was checked by sadrul@chromium.org

[sadrul, 2016-11-28 16:50:03]

The patchset sent to the CQ was uploaded after l-g-t-m from fsamuel@chromium.org
Link to the patchset: https://codereview.chromium.org/2534663002/#ps40001
(title: ".")

[commit-bot: I haz the power, 2016-11-28 16:50:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 17:43:26]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480351803073900,
"parent_rev": "b2044adab67bd4f7586631f25afc64e3d1856b68", "commit_rev":
"f3690baa1f09dc9b10b2107ef26acafde7c3e40b"}

[commit-bot: I haz the power, 2016-11-28 17:44:00]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-28 17:46:41]

Description was changed from

==========
mus: Move MusGpuMemoryBufferManager into common.

MusGpuMemoryBufferManager needs to be used by both the window server (to
service gpu memory requests from clients), and the gpu process (for the
display compositor). So move it into a service_common that various server
components can use.

BUG=none
==========

to

==========
mus: Move MusGpuMemoryBufferManager into common.

MusGpuMemoryBufferManager needs to be used by both the window server (to
service gpu memory requests from clients), and the gpu process (for the
display compositor). So move it into a service_common that various server
components can use.

BUG=none

Committed: https://crrev.com/d9ea7ed90d1de14db8eca3ed1df66c6851f13648
Cr-Commit-Position: refs/heads/master@{#434681}
==========

[commit-bot: I haz the power, 2016-11-28 17:46:42]

Patchset 3 (id:??) landed as
https://crrev.com/d9ea7ed90d1de14db8eca3ed1df66c6851f13648
Cr-Commit-Position: refs/heads/master@{#434681}