Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 2534463002: [fullcodegen] Remove deprecated support for class literals. (Closed)

Created:
4 years ago by rmcilroy
Modified:
4 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[fullcodegen] Remove deprecated support for class literals. This code is no longer used in full-codegen or ast-graph-builder since all functions which have class literals go through Ignition first. BUG=v8:5657 Committed: https://crrev.com/abf4c01d437b20f806d879e57717890d992d7b70 Cr-Commit-Position: refs/heads/master@{#41282}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -674 lines) Patch
M src/compiler/ast-graph-builder.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 3 chunks +1 line, -132 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +0 lines, -54 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +0 lines, -54 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +2 lines, -35 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -52 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +0 lines, -54 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +0 lines, -54 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +0 lines, -54 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 chunk +0 lines, -52 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +0 lines, -51 lines 0 comments Download
src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +0 lines, -52 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-classes.cc View 1 chunk +2 lines, -20 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (8 generated)
rmcilroy
Benedikt, PTAL, thanks.
4 years ago (2016-11-24 17:46:13 UTC) #6
Benedikt Meurer
Wohoo! Awesome, I love it! LGTM
4 years ago (2016-11-24 18:08:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2534463002/1
4 years ago (2016-11-25 08:48:00 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-25 08:49:46 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-25 08:50:28 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/abf4c01d437b20f806d879e57717890d992d7b70
Cr-Commit-Position: refs/heads/master@{#41282}

Powered by Google App Engine
This is Rietveld 408576698